From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [RFC 03/11] malloc: index heaps using heap ID rather
 than NUMA node
Date: Fri, 13 Jul 2018 17:08:28 +0100
Message-ID: <7e5fa73f-7006-44d5-3e31-40cb7a948f9c@intel.com>
References: <cover.1530881548.git.anatoly.burakov@intel.com>
 <be19bfbab392b3938a40f70ca60d9600caffa6be.1530881548.git.anatoly.burakov@intel.com>
 <CAD+H993L5HRt8q4mtDUZksFyWX0WPqT-rOPvvpPWc_6kmt5NoQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
 srinath.mannam@broadcom.com, scott.branden@broadcom.com,
 Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 6FFAB10B7
 for <dev@dpdk.org>; Fri, 13 Jul 2018 18:08:50 +0200 (CEST)
In-Reply-To: <CAD+H993L5HRt8q4mtDUZksFyWX0WPqT-rOPvvpPWc_6kmt5NoQ@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 13-Jul-18 5:05 PM, Alejandro Lucero wrote:
>> -       /* get pointer to global configuration */
>> -       mcfg = rte_eal_get_configuration()->mem_config;
>> -
>> -       for (i = 0; i < RTE_MAX_NUMA_NODES; i++) {
>> -               if ((socket != SOCKET_ID_ANY) && (socket != i))
>> +       for (idx = 0; idx < rte_socket_count(); idx++) {
>> +               int cur_socket = rte_socket_id_by_idx(idx);
>> +               if ((socket != SOCKET_ID_ANY) && (socket != cur_socket))
>>                          continue;
>>
>> -               malloc_heap_get_stats(&mcfg->malloc_heaps[i], &stats);
>> -               if (stats.greatest_free_size > len) {
>> -                       len = stats.greatest_free_size;
>> -                       *s = i;
>> +               size_t cur_len = heap_max_free_elem(idx, align);
>> +               if (cur_len > len) {
>> +                       len = cur_len;
>> +                       *s = cur_socket;
>>                  }
>>          }
>>
>> -       if (len < MALLOC_ELEM_OVERHEAD + align)
>> -               return 0;
>> -
>> -       return len - MALLOC_ELEM_OVERHEAD - align;
>> +       return len;
>>
> 
> Is it worth to set *s to some safe value if no space at all?

No, the value of *s is set externally anyway, and is not used of return 
value is 0.

Thanks for other comments, will fix when the next iteration comes.


-- 
Thanks,
Anatoly