From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH] bus/vdev: fix wrong error log on secondary
	device scan
Date: Mon, 27 Aug 2018 17:16:28 +0100
Message-ID: <7ea4dd19-cd84-7b40-e0b9-ff25b85d6769@intel.com>
References: <20180827122732.5531-1-qi.z.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: gage.eads@intel.com, stable@dpdk.org
To: Qi Zhang <qi.z.zhang@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20180827122732.5531-1-qi.z.zhang@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 27-Aug-18 1:27 PM, Qi Zhang wrote:
> When a secondary process handles VDEV_SCAN_ONE mp action, it is possible
> the device is already be inserted. This happens when we have multiple
> secondary processes which cause multiple broadcasts from primary during
> bus->scan. So we don't need to log any error for -EEXIST.
> 
> Bugzilla ID: 84
> Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel")
> Cc: stable@dpdk.org
> 
> Reported-by: Eads Gage <gage.eads@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>   drivers/bus/vdev/vdev.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
> index 6139dd551..af9526fe6 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -346,6 +346,7 @@ vdev_action(const struct rte_mp_msg *mp_msg, const void *peer)
>   	const struct vdev_param *in = (const struct vdev_param *)mp_msg->param;
>   	const char *devname;
>   	int num;
> +	int ret;
>   
>   	strlcpy(mp_resp.name, VDEV_MP_KEY, sizeof(mp_resp.name));
>   	mp_resp.len_param = sizeof(*ou);
> @@ -380,7 +381,10 @@ vdev_action(const struct rte_mp_msg *mp_msg, const void *peer)
>   		break;
>   	case VDEV_SCAN_ONE:
>   		VDEV_LOG(INFO, "receive vdev, %s", in->name);
> -		if (insert_vdev(in->name, NULL, NULL) < 0)
> +		ret = insert_vdev(in->name, NULL, NULL);
> +		if (ret == -EEXIST)
> +			VDEV_LOG(INFO, "device already exist, %s", in->name);

This is probably going to be printed a lot, and there's no real point in 
that. Maybe set log level to DEBUG instead?

> +		else if (ret < 0)
>   			VDEV_LOG(ERR, "failed to add vdev, %s", in->name);
>   		break;
>   	default:
> 


-- 
Thanks,
Anatoly