From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [RFC v2] /net: memory interface (memif)
Date: Mon, 10 Dec 2018 10:42:51 +0000
Message-ID: <7ebcd985-0d04-c0e1-5411-8e02c8bc72b2@intel.com>
References: <20181210091457.6031-1-jgrajcia@cisco.com>
 <20181210100639.30244-1-jgrajcia@cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Jakub Grajciar <jgrajcia@cisco.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 133745F72
 for <dev@dpdk.org>; Mon, 10 Dec 2018 11:42:53 +0100 (CET)
In-Reply-To: <20181210100639.30244-1-jgrajcia@cisco.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10-Dec-18 10:06 AM, Jakub Grajciar wrote:
> Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
> ---

As a general comment, some description/cover letter would have been nice.

> +
> +	memif_msg_disconnect_t *d = &e->msg.disconnect;
> +
> +	e->msg.type = MEMIF_MSG_TYPE_DISCONNECT;
> +	d->code = err_code;
> +
> +	if (reason != NULL) {
> +		strncpy((char *)d->string, reason, strlen(reason));
> +		if (cc->pmd != NULL) {
> +			strncpy(cc->pmd->local_disc_string, reason,
> +				strlen(reason));
> +		}

I haven't looked at the entire thing, this is just something that caught 
my eye during quick skimming through code.

On the face of it, this looks dangerous - you're setting the destination 
buffer size from source buffer size. What if `d->string` is shorter than 
`reason`?


-- 
Thanks,
Anatoly