From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v4] ethdev: return diagnostic when setting MAC address Date: Wed, 11 Apr 2018 20:30:06 +0100 Message-ID: <7ee01247-c08d-41b1-baae-b7edfb7f2487@intel.com> References: <20180406153444.23988-1-olivier.matz@6wind.com> <20180411163251.10063-1-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Thomas Monjalon , Tomasz Duszynski , Andrew Rybchenko , Adrien Mazarguil , Shreyansh Jain , Nelio Laranjeiro , Ivan Malov To: Olivier Matz , dev@dpdk.org Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 45FD71B76E for ; Wed, 11 Apr 2018 21:30:11 +0200 (CEST) In-Reply-To: <20180411163251.10063-1-olivier.matz@6wind.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/11/2018 5:32 PM, Olivier Matz wrote: > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > return code is added to notify the caller (librte_ether) if an error > occurred in the PMD. > > The new default MAC address is now copied in dev->data->mac_addrs[0] > only if the operation is successful. > > The patch also updates all the PMDs accordingly. > > Signed-off-by: Olivier Matz > Signed-off-by: Ivan Malov > Acked-by: Andrew Rybchenko > Acked-by: Adrien Mazarguil > Acked-by: Shreyansh Jain > Reviewed-by: Ferruh Yigit > Acked-by: Thomas Monjalon > Acked-by: Nelio Laranjeiro Applied to dpdk-next-net/master, thanks.