From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Rybchenko Subject: Re: [PATCH v5 00/20] Decouple ethdev from PCI device Date: Fri, 6 Jan 2017 13:07:44 +0300 Message-ID: <7f68e370-4bee-9d87-e182-3bcda066a07e@solarflare.com> References: <1482332986-7599-1-git-send-email-jblunck@infradead.org> <1482508691-11408-1-git-send-email-jblunck@infradead.org> <3218207.eTF77IRQHx@xps13> <2be3d632-b1eb-d7be-47e3-c6e9211fef33@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , , , Alejandro Lucero To: Ferruh Yigit , Thomas Monjalon , Jan Blunck Return-path: Received: from nbfkord-smmo02.seg.att.com (nbfkord-smmo02.seg.att.com [209.65.160.78]) by dpdk.org (Postfix) with ESMTP id 895852B8B for ; Fri, 6 Jan 2017 11:08:35 +0100 (CET) In-Reply-To: <2be3d632-b1eb-d7be-47e3-c6e9211fef33@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01/03/2017 03:20 PM, Ferruh Yigit wrote: > On 12/25/2016 10:33 PM, Thomas Monjalon wrote: >> 2016-12-23 16:57, Jan Blunck: >>> This repost addresses the review comments of Thomas Monjalon to completely >>> remove the ethdev helper to further decrease the coupling of the ethdev and >>> the eal layers. This required me to squash together all patches using the >>> rte_eth_dev_to_pci() helper into "Decouple from PCI device" patch. As >>> discussed privately I'll keep the PCI information in rte_eth_dev_info >>> untouched. >> Applied with some trivial fixes, thanks >> > I rebased these changes into next-net tree. And need to update some sfc > and nfp patches [1] there. > > Andrew, Alejandro, > > Can you please review your driver in the latest next-net tree? > > Thanks, > ferruh > > [1] > nfp: > net/nfp: add Rx interrupts > > sfc: > net/sfc: support link status change interrupt > net/sfc: interrupts support sufficient for event queue init > net/sfc: implement driver operation to init device on attach > net/sfc: libefx-based PMD stub sufficient to build and init Ferruh, thanks that you care about it. I've reviewed and tested it. It looks and works fine for me. Andrew.