From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH] kvargs: fix building with meson outside
 source tree
Date: Thu, 19 Jul 2018 15:45:01 +0100
Message-ID: <7f7269e5-e439-6655-4fe8-7c0e9166f35d@intel.com>
References: <20180719142648.44824-1-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 9EF993572
 for <dev@dpdk.org>; Thu, 19 Jul 2018 16:45:04 +0200 (CEST)
In-Reply-To: <20180719142648.44824-1-bruce.richardson@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 19-Jul-18 3:26 PM, Bruce Richardson wrote:
> When building DPDK with meson with the <builddir> being outside the source
> directory, an error was generated as the path to the EAL headers was not
> found. The path specified for the includes backed out unnecessarily far and
> so broke when the build directory was not in the expected location of
> just inside the source dir. Changing the path to be shorter, just going
> down one level and then into EAL builds for both cases - where builddir is
> in source directory, and also when it's outside it.
> 
> Fixes: 092ee516496d ("kvargs: build before EAL")
> 
> Reported-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>   lib/librte_kvargs/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_kvargs/meson.build b/lib/librte_kvargs/meson.build
> index a1c724961..acd3e5432 100644
> --- a/lib/librte_kvargs/meson.build
> +++ b/lib/librte_kvargs/meson.build
> @@ -2,7 +2,7 @@
>   # Copyright(c) 2017 Intel Corporation
>   
>   includes = [global_inc]
> -includes += include_directories('../../../lib/librte_eal/common/include')
> +includes += include_directories('../librte_eal/common/include')
>   
>   version = 1
>   sources = files('rte_kvargs.c')
> 

Tested-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly