From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4 3/6] kni: set default carrier state of
	interface
Date: Wed, 17 Oct 2018 16:20:37 +0100
Message-ID: <7faa26ad-9f93-446a-4d48-d62d013694d2@intel.com>
References: <20180911232906.18352-1-dg@adax.com>
 <20181017010412.23141-4-dg@adax.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Igor Ryzhov <iryzhov@nfware.com>,
 Stephen Hemminger <stephen@networkplumber.org>
To: Dan Gora <dg@adax.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 9D3235F0D
 for <dev@dpdk.org>; Wed, 17 Oct 2018 17:20:40 +0200 (CEST)
In-Reply-To: <20181017010412.23141-4-dg@adax.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/17/2018 2:04 AM, Dan Gora wrote:
> +static int __init
> +kni_parse_carrier_state(void)
> +{
> +	if (!carrier)
> +		dflt_carrier = 0;
> +
> +	if (strcmp(carrier, "off") == 0)
> +		dflt_carrier = 0;
> +	else if (strcmp(carrier, "on") == 0)
> +		dflt_carrier = 1;
> +	else
> +		return -1;
> +
> +	return 0;
> +}

I think intention here is:

 if (!carrier)
 	return 0;