From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v3 1/5] vhost: unify VhostUserMsg usage
Date: Thu, 20 Sep 2018 16:56:15 +0100
Message-ID: <7fe10407-c03a-1899-d4cc-d4f27833d317@intel.com>
References: <153698873346.23049.10966616323159180622.stgit@T460>
 <153698882681.23049.10483393218056672951.stgit@T460>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Nikolay Nikolaev <nicknickolaev@gmail.com>, maxime.coquelin@redhat.com,
 tiwei.bie@intel.com, zhihong.wang@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 64E0E5F65
 for <dev@dpdk.org>; Thu, 20 Sep 2018 17:58:34 +0200 (CEST)
In-Reply-To: <153698882681.23049.10483393218056672951.stgit@T460>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 15-Sep-18 6:20 AM, Nikolay Nikolaev wrote:
> Use the typedef version of struct VhostUserMsg. Also unify the related
> parameter name.
> 
> Signed-off-by: Nikolay Nikolaev <nicknickolaev@gmail.com>
> ---

I'm probably missing some background on this, but according to DPDK 
coding style guide, typedef structs are to be avoided [1].

[1] 
https://doc.dpdk.org/guides-18.08/contributing/coding_style.html#typedefs

-- 
Thanks,
Anatoly