From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 05/10] ethdev: new API to get dcb related information Date: Fri, 30 Oct 2015 12:16:40 +0100 Message-ID: <80355980.tZqCmrPgr9@xps13> References: <1443074591-19803-1-git-send-email-jingjing.wu@intel.com> <1446108827-7907-1-git-send-email-jingjing.wu@intel.com> <1446108827-7907-6-git-send-email-jingjing.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Jingjing Wu Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 9CE075A4F for ; Fri, 30 Oct 2015 12:17:51 +0100 (CET) Received: by wmff134 with SMTP id f134so9310597wmf.0 for ; Fri, 30 Oct 2015 04:17:51 -0700 (PDT) In-Reply-To: <1446108827-7907-6-git-send-email-jingjing.wu@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-10-29 16:53, Jingjing Wu: > This patch adds one new API to get dcb related info. > rte_eth_dev_get_dcb_info > > Signed-off-by: Jingjing Wu > --- > lib/librte_ether/rte_ethdev.c | 18 +++++++++++++++ > lib/librte_ether/rte_ethdev.h | 54 +++++++++++++++++++++++++++++++++++++++++++ You forgot to update the .map file. So there are some build errors later: undefined reference to `rte_eth_dev_get_dcb_info' Jijiang, Helin, and other reviewers generally, please try to catch this kind of errors (.map, doc) as they are quite common and make the integration process slower when I catch it only at the end. Better are the patches, more will be integrated. Thanks