From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [PATCH v2 01/15] ethdev: add error types to flow API
Date: Sat, 7 Apr 2018 12:15:49 +0300
Message-ID: <804ca327-c2d8-4ef8-dd15-7ddcefc7ac99@solarflare.com>
References: <20180404150312.12304-1-adrien.mazarguil@6wind.com>
 <20180406131736.19145-1-adrien.mazarguil@6wind.com>
 <20180406131736.19145-2-adrien.mazarguil@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>, Thomas Monjalon
 <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 22D521C805
 for <dev@dpdk.org>; Sat,  7 Apr 2018 11:16:00 +0200 (CEST)
In-Reply-To: <20180406131736.19145-2-adrien.mazarguil@6wind.com>
Content-Language: en-GB
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 04/06/2018 04:25 PM, Adrien Mazarguil wrote:
> These enable more precise reporting of objects responsible for errors.
>
> This breaks ABI compatibility for the following public functions:
>
> - rte_flow_create()
> - rte_flow_destroy()
> - rte_flow_error_set()
> - rte_flow_flush()
> - rte_flow_isolate()
> - rte_flow_query()
> - rte_flow_validate()
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> ---
>   app/test-pmd/config.c                   |  4 ++++
>   lib/librte_ether/rte_ethdev_version.map | 20 +++++++++++++-------
>   lib/librte_ether/rte_flow.h             |  4 ++++
>   3 files changed, 21 insertions(+), 7 deletions(-)

I think PMD maintainers with flow API support should be additionally
notified and encouraged to refine error reporting.