From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>, dev@dpdk.org
Subject: Re: [PATCH] nfp: using random mac address if not a configured mac
Date: Tue, 13 Sep 2016 18:15:43 +0100 [thread overview]
Message-ID: <804cc3e9-a13a-6252-5786-d6a4471bc4c8@intel.com> (raw)
In-Reply-To: <9fbfe918-5a09-46c1-2c85-928fac9d7c0d@intel.com>
On 9/13/2016 6:10 PM, Ferruh Yigit wrote:
> Hi Alejandro,
>
> On 8/16/2016 4:15 PM, Alejandro Lucero wrote:
>> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
>> ---
>
> There are following checkpatch warnings, also check-git-log complains:
>
> Headline too long:
> nfp: unregister interrupt callback function when closing device
>
copy-paste error, this one gives following, again because of "mac" usage:
Wrong headline lowercase:
nfp: using random mac address if not a configured mac
> ...
>
>>
>> +static void nfp_net_read_mac(struct nfp_net_hw *hw) {
>> +
>
> ERROR:OPEN_BRACE: open brace '{' following function declarations go on
> the next line
> #45: FILE: drivers/net/nfp/nfp_net.c:620:
> +static void nfp_net_read_mac(struct nfp_net_hw *hw) {
>
> ...
>
>> + if (!is_valid_assigned_ether_addr((struct ether_addr *)&hw->mac_addr[0]))
>
> WARNING:LONG_LINE: line over 80 characters
> #67: FILE: drivers/net/nfp/nfp_net.c:2419:
> + if (!is_valid_assigned_ether_addr((struct ether_addr
> *)&hw->mac_addr[0]))
>
>> + /* Using random mac addresses for VFs */
>
next prev parent reply other threads:[~2016-09-13 17:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 15:15 [PATCH] nfp: using random mac address if not a configured mac Alejandro Lucero
2016-09-13 17:10 ` Ferruh Yigit
2016-09-13 17:15 ` Ferruh Yigit [this message]
2016-09-13 19:30 ` Thomas Monjalon
2016-09-16 7:49 ` Alejandro Lucero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=804cc3e9-a13a-6252-5786-d6a4471bc4c8@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).