From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-stable] [PATCH v2] eal: initialize alarms early
Date: Tue, 02 Apr 2019 15:01:14 +0200
Message-ID: <8055087.Rpa7nGxINI@xps>
References: <20190326184331.13850-1-dariusz.stojaczyk@intel.com>
 <20190401141814.8096-1-dariusz.stojaczyk@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: stable@dpdk.org, dev@dpdk.org, bruce.richardson@intel.com,
 Qi Zhang <qi.z.zhang@intel.com>, Anatoly Burakov <anatoly.burakov@intel.com>
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20190401141814.8096-1-dariusz.stojaczyk@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

01/04/2019 16:18, Darek Stojaczyk:
> On linux, we currently initialize rte_alarms after
> starting to listen for IPC hotplug requests, which gives
> us a data race window. Upon receiving such hotplug
> request we always try to set an alarm and this obviously
> doesn't work if the alarms weren't initialized yet.
> 
> To fix it, we initialize alarms before starting to
> listen for IPC hotplug messages. Specifically, we move
> rte_eal_alarm_init() right after rte_eal_intr_init() as
> it makes some sense to keep those two close to each other.
> 
> We update the bsd code as well to keep the initialization
> order the same in both eal implementations.
> 
> Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
> Cc: Qi Zhang <qi.z.zhang@intel.com>
> Cc: Anatoly Burakov <anatoly.burakov@intel.com>
> Cc: stable@dpdk.org
> 
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> ---
> v2:
>  - updated the bsd code as well (Thomas)

Applied, thanks