From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2] virtio: use zeroed memory for simple TX
	header
Date: Wed, 06 Apr 2016 12:28:37 +0200
Message-ID: <8066893.ezGm9hkDan@xps13>
References: <1459822261-95284-1-git-send-email-rlane@bigswitch.com>
 <20160405042513.GM3080@yliu-dev.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Yuanhan Liu <yuanhan.liu@linux.intel.com>,
 Huawei Xie <huawei.xie@intel.com>,
 Stephen Hemminger <stephen@networkplumber.org>
To: Rich Lane <rich.lane@bigswitch.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 36F1F2617
 for <dev@dpdk.org>; Wed,  6 Apr 2016 12:30:16 +0200 (CEST)
Received: by mail-wm0-f52.google.com with SMTP id n3so56607022wmn.0
 for <dev@dpdk.org>; Wed, 06 Apr 2016 03:30:16 -0700 (PDT)
In-Reply-To: <20160405042513.GM3080@yliu-dev.sh.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > For simple TX the virtio-net header must be zeroed, but it was using memory
> > that had been initialized with indirect descriptor tables. This resulted in
> > "unsupported gso type" errors from librte_vhost.
> > 
> > We can use the same memory for every descriptor to save cachelines in the
> > vswitch.
> > 
> > Fixes: 6dc5de3a (virtio: use indirect ring elements)
> > Signed-off-by: Rich Lane <rlane@bigswitch.com>
> 
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

Applied, thanks