From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v5 0/2] clean up interrupt handle
Date: Tue, 04 Apr 2017 16:50:01 +0200
Message-ID: <8091532.IGg7nCNBxL@xps13>
References: <20170404212125.32114-1-qi.z.zhang@intel.com>
 <20170404222732.981-1-qi.z.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Qi Zhang <qi.z.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com
 [209.85.128.173]) by dpdk.org (Postfix) with ESMTP id CDED8326B
 for <dev@dpdk.org>; Tue,  4 Apr 2017 16:50:03 +0200 (CEST)
Received: by mail-wr0-f173.google.com with SMTP id w43so216447674wrb.0
 for <dev@dpdk.org>; Tue, 04 Apr 2017 07:50:03 -0700 (PDT)
In-Reply-To: <20170404222732.981-1-qi.z.zhang@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-04-05 06:27, Qi Zhang:
> It seems its not necessary to register an intr_handle for interrupt callback
> function. "void* cb_arg" shows enough when be used to pass the object that
> contain the information be required to handle the interrupt event( A typical
> way which is implemented by almost all driver is by passing a rte_ethdev
> instance).
> The patch change the prototype of rte_intr_callback_fn by removing
> the uncessary intr_handle paramter.
> 
> v5:
> 
> - Update mlx4 driver which is missed in previous version.
> 
> v4:
> 
> - Update mlx5 driver which is missed in v1, v2, v3.
> - Add back patch 1 of v2 to make this complete though it already be applied.
> - Remove patch 3 which is not necessary with latest master.

Why have you removed patch 3?

There is this error now:

test/test/test_interrupts.c:217:4: fatal error:
incompatible pointer types passing 'void (struct rte_intr_handle *, void *)'
to parameter of type 'rte_intr_callback_fn' (aka 'void (*)(void *)')
[-Wincompatible-pointer-types]
                        test_interrupt_callback, arg) >= 0) {