From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [PATCH v2 05/11] ethdev: add probing finish function
Date: Thu, 10 May 2018 14:24:16 +0300
Message-ID: <80b51b0d-dcec-3dcc-8f2a-cd06e4b7cbf8@solarflare.com>
References: <20180509094337.26112-1-thomas@monjalon.net>
 <20180509224313.27289-6-thomas@monjalon.net>
 <0b071bfa-29e0-b014-1991-ef500b870a07@solarflare.com>
 <3910255.F1yzIlvK5u@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 195251B7C1
 for <dev@dpdk.org>; Thu, 10 May 2018 13:24:28 +0200 (CEST)
In-Reply-To: <3910255.F1yzIlvK5u@xps>
Content-Language: en-GB
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 05/10/2018 01:54 PM, Thomas Monjalon wrote:
> 10/05/2018 12:37, Andrew Rybchenko:
>> On 05/10/2018 01:43 AM, Thomas Monjalon wrote:
>>> A new hook function is added and called inside the PMDs at the end
>>> of the device probing:
>>> 	- in primary process, after allocating, init and config
>>> 	- in secondary process, after attaching and local init
>>>
>>> This new function is almost empty for now.
>>> It will be used later to add some post-initialization processing.
>>>
>>> For the PMDs calling the helpers rte_eth_dev_create() or
>>> rte_eth_dev_pci_generic_probe(), the hook rte_eth_dev_probing_finish()
>>> is called from here, and not in the PMD itself.
>>>
>>> Note that the helper rte_eth_dev_create() could be used more,
>>> especially for vdevs, avoiding some code duplication in PMDs.
>>>
>>> Cc: stable@dpdk.org
>> Why Cc?
> Because other fixes in the series depend on this patch.

Yes, I've realized it reviewing later patches. Thanks.