From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/2] eal/ppc: fix mmap for memory initialization Date: Thu, 20 Apr 2017 09:39:09 +0200 Message-ID: <8100178.UKWLChnxCa@xps> References: <1491473170-25160-1-git-send-email-chaozhu@linux.vnet.ibm.com> <1491473170-25160-2-git-send-email-chaozhu@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Gowrishankar , sergio.gonzalez.monroy@intel.com, david.marchand@6wind.com To: Chao Zhu Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0F1FF2BAE for ; Thu, 20 Apr 2017 09:39:11 +0200 (CEST) In-Reply-To: <1491473170-25160-2-git-send-email-chaozhu@linux.vnet.ibm.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/04/2017 12:06, Chao Zhu: > On IBM POWER platform, when mapping /dev/zero file to hugepage memory > space, mmap will not respect the requested address hint. This will cause > the memory initilization for the second process fails. This patch adds > the required mmap flags to make it work. Beside this, users need to set > the nr_overcommit_hugepages to expand the VA range. When > doing the initilization, users need to set both nr_hugepages and > nr_overcommit_hugepages to the same value, like 64, 128, etc. > > Signed-off-by: Chao Zhu > --- > lib/librte_eal/linuxapp/eal/eal_memory.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c > b/lib/librte_eal/linuxapp/eal/eal_memory.c index a956bb2..e06186b 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_memory.c > +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c > @@ -313,7 +313,11 @@ int rte_xen_dom0_supported(void) > } > do { > addr = mmap(addr, > +#ifndef RTE_ARCH_PPC_64 > (*size) + hugepage_sz, PROT_READ, MAP_PRIVATE, fd, 0); > +#else > + (*size) + hugepage_sz, PROT_READ, MAP_PRIVATE | > MAP_ANONYMOUS | MAP_HUGETLB, fd, 0); +#endif > if (addr == MAP_FAILED) > *size -= hugepage_sz; > } while (addr == MAP_FAILED && *size > 0); > @@ -1330,7 +1334,11 @@ static int huge_wrap_sigsetjmp(void) > * use mmap to get identical addresses as the primary process. > */ > base_addr = mmap(mcfg->memseg[s].addr, mcfg->memseg[s].len, > +#ifndef RTE_ARCH_PPC_64 > PROT_READ, MAP_PRIVATE, fd_zero, 0); > +#else > + PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS | MAP_HUGETLB, > fd_zero, 0); +#endif > if (base_addr == MAP_FAILED || > base_addr != mcfg->memseg[s].addr) { > max_seg = s; Indentation and line length are wrong. Changed to this: --- a/lib/librte_eal/linuxapp/eal/eal_memory.c +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c @@ -331,7 +331,13 @@ get_virtual_area(size_t *size, size_t hugepage_sz) } do { addr = mmap(addr, - (*size) + hugepage_sz, PROT_READ, MAP_PRIVATE, fd, 0); + (*size) + hugepage_sz, PROT_READ, +#ifdef RTE_ARCH_PPC_64 + MAP_PRIVATE | MAP_ANONYMOUS | MAP_HUGETLB, +#else + MAP_PRIVATE, +#endif + fd, 0); if (addr == MAP_FAILED) *size -= hugepage_sz; } while (addr == MAP_FAILED && *size > 0); @@ -1359,7 +1365,13 @@ rte_eal_hugepage_attach(void) * use mmap to get identical addresses as the primary process. */ base_addr = mmap(mcfg->memseg[s].addr, mcfg->memseg[s].len, - PROT_READ, MAP_PRIVATE, fd_zero, 0); + PROT_READ, +#ifdef RTE_ARCH_PPC_64 + MAP_PRIVATE | MAP_ANONYMOUS | MAP_HUGETLB, +#else + MAP_PRIVATE, +#endif + fd_zero, 0); if (base_addr == MAP_FAILED || base_addr != mcfg->memseg[s].addr) { max_seg = s;