From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Charles (Chas) Williams" <ciwillia@brocade.com>
Subject: Re: [PATCH 2/3] net/af_packet: add accessor for iface
Date: Mon, 22 May 2017 09:20:52 -0400
Message-ID: <814c1db3-0be7-b18e-f6cd-0cb6acb8728c@brocade.com>
References: <1495044215-16915-1-git-send-email-ciwillia@brocade.com>
 <1495044215-16915-2-git-send-email-ciwillia@brocade.com>
 <4fdc5000-66c1-ff96-6330-20a3cc92d900@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <linville@tuxdriver.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mx0a-000f0801.pphosted.com (mx0b-000f0801.pphosted.com
 [67.231.152.113]) by dpdk.org (Postfix) with ESMTP id 60DD928EE
 for <dev@dpdk.org>; Mon, 22 May 2017 15:20:56 +0200 (CEST)
In-Reply-To: <4fdc5000-66c1-ff96-6330-20a3cc92d900@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 05/22/2017 05:39 AM, Ferruh Yigit wrote:
> Hi Chas,
>
> On 5/17/2017 7:03 PM, Charles (Chas) Williams wrote:
>> Provide an accessor for the name of the underlying linux interface
>> used by the AF_PACKET-based interface.
>
> This patch provides a PMD specific API to get PMD internal data
> (internals->if_name).
>
> I think we should avoid PMD specific APIs if possible.
>
> internals->if_name is provided by application, as devargs to af_packet
> (iface=..), so app already knows port_id -> if_name mapping.
>
> OR
>
> With rte_eth_dev_info_get() af_packet returns the if_index for
> underlying interface, it is possible to use if_indextoname() to get ifname.
>
> Because above methods exists to get if_name, I think this API is not
> necessary.

I will go this route then.

>>
>> Signed-off-by: Charles (Chas) Williams <ciwillia@brocade.com>
>
> <...>
>