From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 10/13] KNI: provided netif name's source is user-space Date: Wed, 14 Dec 2016 17:06:23 +0000 Message-ID: <817f957e-80c3-bfc0-e02b-55f397581708@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , dev@dpdk.org Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id DB3F5370 for ; Wed, 14 Dec 2016 18:06:26 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Michal, On 12/13/2016 1:08 AM, Michał Mirosław wrote: > Signed-off-by: Michał Mirosław > --- > lib/librte_eal/linuxapp/kni/kni_misc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c > index 497db9b..f0247aa 100644 > --- a/lib/librte_eal/linuxapp/kni/kni_misc.c > +++ b/lib/librte_eal/linuxapp/kni/kni_misc.c > @@ -363,8 +363,8 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num, > up_read(&knet->kni_list_lock); > > net_dev = alloc_netdev(sizeof(struct kni_dev), dev_info.name, > -#ifdef NET_NAME_UNKNOWN > - NET_NAME_UNKNOWN, > +#ifdef NET_NAME_USER > + NET_NAME_USER, Probably NET_NAME_USER fits better to definition. But functionally, I wonder if you have a use case to use "name_assign_type" ? > #endif > kni_net_init); > if (net_dev == NULL) { >