From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCHv2 1/4] pmdinfogen: Add buildtools and pmdinfogen utility Date: Thu, 19 May 2016 10:51:19 +0300 Message-ID: <81cef5e5-3220-710f-aebf-a703c1423199@redhat.com> References: <1463431287-4551-1-git-send-email-nhorman@tuxdriver.com> <1463605687-649-1-git-send-email-nhorman@tuxdriver.com> <1463605687-649-2-git-send-email-nhorman@tuxdriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Bruce Richardson , Thomas Monjalon , Stephen Hemminger To: Neil Horman , dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C9C888D39 for ; Thu, 19 May 2016 09:51:22 +0200 (CEST) In-Reply-To: <1463605687-649-2-git-send-email-nhorman@tuxdriver.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/19/2016 12:08 AM, Neil Horman wrote: [...] > + if (strcmp(secname, ".modinfo") == 0) { > + if (nobits) > + fprintf(stderr, "%s has NOBITS .modinfo\n", filename); > + info->modinfo = (void *)hdr + sechdrs[i].sh_offset; > + info->modinfo_len = sechdrs[i].sh_size; > + } else if (strcmp(secname, "__ksymtab") == 0) > + info->export_sec = i; > + else if (strcmp(secname, "__ksymtab_unused") == 0) > + info->export_unused_sec = i; > + else if (strcmp(secname, "__ksymtab_gpl") == 0) > + info->export_gpl_sec = i; > + else if (strcmp(secname, "__ksymtab_unused_gpl") == 0) > + info->export_unused_gpl_sec = i; > + else if (strcmp(secname, "__ksymtab_gpl_future") == 0) > + info->export_gpl_future_sec = i; > + Looks like a leftover from kernel modpost.c, not needed in DPDK. - Panu -