From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] telemetry: fix incorrect stat name to id mapping Date: Tue, 02 Apr 2019 02:34:15 +0200 Message-ID: <8225282.udm7ztb7Ro@xps> References: <20190328153045.8178-1-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Laatz, Kevin" , stable@dpdk.org To: Bruce Richardson Return-path: In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/04/2019 19:17, Laatz, Kevin: > On 28/03/2019 15:30, Bruce Richardson wrote: > > If we have two NIC ports which have a different set of NIC stats we can > > end up having two different stats registered with xstats with the same > > name. [Since the stats are updated in bulk as a contiguous set, the > > second driver re-using the registration of the first is not possible.] > > > > This causes issues with the invalid stat for one driver being found due to > > a lookup by name which is unnecessary. Instead of getting stat names > > involved do the lookup by ID instead. > > > > CC: stable@dpdk.org > > Fixes: 1b756087db93 ("telemetry: add parser for client socket messages") > > > > Signed-off-by: Bruce Richardson > > --- > > Looks good to me! Thanks. > > Acked-by: Kevin Laatz Applied, thanks