* [PATCH] drivers/net: reorder Intel drivers list in meson script
@ 2026-01-23 16:21 Thierry Herbelot
2026-01-23 16:27 ` [V2] " Thierry Herbelot
2026-02-17 12:48 ` [PATCH] usertools/pmdinfo: fix search for PMD info string Bruce Richardson
0 siblings, 2 replies; 14+ messages in thread
From: Thierry Herbelot @ 2026-01-23 16:21 UTC (permalink / raw)
To: dev
Cc: Thierry Herbelot, Thomas Monjalon, Bruce Richardson,
Anatoly Burakov, stable, Olivier Matz
After an upstream patch (see Fixes), net_ixgbe_vf is no longer declared
in testpmd PMD info, when compiling under Redhat-9:
> [user@vader dpdk]$ meson setup build && ninja -C build
> [user@vader dpdk]$ ./usertools/dpdk-pmdinfo.py build/app/dpdk-testpmd|grep ixgbe
> "name": "net_ixgbe",
Name 'net_ixgbe_vf' should also be reported.
One workaround is to move 'intel/ixgbe' as last in the list of Intel
drivers. This restores net_ixgbe_vf under Redhat-9:
> [user@vader dpdk]$ ./usertools/dpdk-pmdinfo.py build/app/dpdk-testpmd|grep ixgbe
> "name": "net_ixgbe_vf",
> "name": "net_ixgbe",
Fixes: 04f1b16c54f3 ("drivers: merge common and net idpf drivers")
Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
drivers/net/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index c7dae4ad273c..8d96244cdbb0 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -32,8 +32,8 @@ drivers = [
'intel/ice',
'intel/idpf',
'intel/ipn3ke',
- 'intel/ixgbe',
'intel/cpfl', # depends on idpf, so must come after it
+ 'intel/ixgbe',
'ionic',
'mana',
'memif',
--
2.39.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [V2] drivers/net: reorder Intel drivers list in meson script
2026-01-23 16:21 [PATCH] drivers/net: reorder Intel drivers list in meson script Thierry Herbelot
@ 2026-01-23 16:27 ` Thierry Herbelot
2026-01-23 16:50 ` Bruce Richardson
2026-02-17 12:48 ` [PATCH] usertools/pmdinfo: fix search for PMD info string Bruce Richardson
1 sibling, 1 reply; 14+ messages in thread
From: Thierry Herbelot @ 2026-01-23 16:27 UTC (permalink / raw)
To: dev
Cc: Thierry Herbelot, Thomas Monjalon, Bruce Richardson,
Anatoly Burakov, stable, Olivier Matz
After an upstream patch (see Fixes), net_ixgbe_vf is no longer
declared in testpmd PMD info, when compiling under Redhat-9:
> $ meson setup build && ninja -C build
> $ ./usertools/dpdk-pmdinfo.py build/app/dpdk-testpmd|grep ixgbe
> "name": "net_ixgbe",
Name 'net_ixgbe_vf' should also be reported.
One workaround is to move 'intel/ixgbe' as last in the list of Intel
drivers. This restores net_ixgbe_vf under Redhat-9:
> $ meson setup build && ninja -C build
> $ ./usertools/dpdk-pmdinfo.py build/app/dpdk-testpmd|grep ixgbe
> "name": "net_ixgbe_vf",
> "name": "net_ixgbe",
Fixes: 04f1b16c54f3 ("drivers: merge common and net idpf drivers")
Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
V2: use shorter lines in commit log.
---
drivers/net/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index c7dae4ad273c..8d96244cdbb0 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -32,8 +32,8 @@ drivers = [
'intel/ice',
'intel/idpf',
'intel/ipn3ke',
- 'intel/ixgbe',
'intel/cpfl', # depends on idpf, so must come after it
+ 'intel/ixgbe',
'ionic',
'mana',
'memif',
--
2.39.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [V2] drivers/net: reorder Intel drivers list in meson script
2026-01-23 16:27 ` [V2] " Thierry Herbelot
@ 2026-01-23 16:50 ` Bruce Richardson
2026-01-23 16:57 ` Thierry Herbelot
0 siblings, 1 reply; 14+ messages in thread
From: Bruce Richardson @ 2026-01-23 16:50 UTC (permalink / raw)
To: Thierry Herbelot
Cc: dev, Thomas Monjalon, Anatoly Burakov, stable, Olivier Matz
On Fri, Jan 23, 2026 at 05:27:07PM +0100, Thierry Herbelot wrote:
> After an upstream patch (see Fixes), net_ixgbe_vf is no longer
> declared in testpmd PMD info, when compiling under Redhat-9:
>
> > $ meson setup build && ninja -C build
> > $ ./usertools/dpdk-pmdinfo.py build/app/dpdk-testpmd|grep ixgbe
> > "name": "net_ixgbe",
>
> Name 'net_ixgbe_vf' should also be reported.
>
> One workaround is to move 'intel/ixgbe' as last in the list of Intel
> drivers. This restores net_ixgbe_vf under Redhat-9:
>
> > $ meson setup build && ninja -C build
> > $ ./usertools/dpdk-pmdinfo.py build/app/dpdk-testpmd|grep ixgbe
> > "name": "net_ixgbe_vf",
> > "name": "net_ixgbe",
>
> Fixes: 04f1b16c54f3 ("drivers: merge common and net idpf drivers")
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> ---
> V2: use shorter lines in commit log.
> ---
> drivers/net/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/meson.build b/drivers/net/meson.build
> index c7dae4ad273c..8d96244cdbb0 100644
> --- a/drivers/net/meson.build
> +++ b/drivers/net/meson.build
> @@ -32,8 +32,8 @@ drivers = [
> 'intel/ice',
> 'intel/idpf',
> 'intel/ipn3ke',
> - 'intel/ixgbe',
> 'intel/cpfl', # depends on idpf, so must come after it
> + 'intel/ixgbe',
> 'ionic',
> 'mana',
> 'memif',
This is a strange one - did you do any investgation into why or how this
fixes things? You describe it as a workaround so any hints towards a proper
root cause and fix are welcome :-)
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [V2] drivers/net: reorder Intel drivers list in meson script
2026-01-23 16:50 ` Bruce Richardson
@ 2026-01-23 16:57 ` Thierry Herbelot
2026-02-16 10:48 ` Bruce Richardson
0 siblings, 1 reply; 14+ messages in thread
From: Thierry Herbelot @ 2026-01-23 16:57 UTC (permalink / raw)
To: Bruce Richardson
Cc: dev, Thomas Monjalon, Anatoly Burakov, stable, Olivier Matz
On 1/23/26 17:50, Bruce Richardson wrote:
> On Fri, Jan 23, 2026 at 05:27:07PM +0100, Thierry Herbelot wrote:
>> After an upstream patch (see Fixes), net_ixgbe_vf is no longer
>> declared in testpmd PMD info, when compiling under Redhat-9:
>>
>>> $ meson setup build && ninja -C build
>>> $ ./usertools/dpdk-pmdinfo.py build/app/dpdk-testpmd|grep ixgbe
>>> "name": "net_ixgbe",
>>
>> Name 'net_ixgbe_vf' should also be reported.
>>
>> One workaround is to move 'intel/ixgbe' as last in the list of Intel
>> drivers. This restores net_ixgbe_vf under Redhat-9:
>>
>>> $ meson setup build && ninja -C build
>>> $ ./usertools/dpdk-pmdinfo.py build/app/dpdk-testpmd|grep ixgbe
>>> "name": "net_ixgbe_vf",
>>> "name": "net_ixgbe",
>>
>> Fixes: 04f1b16c54f3 ("drivers: merge common and net idpf drivers")
>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
>> ---
>> V2: use shorter lines in commit log.
>> ---
>> drivers/net/meson.build | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/meson.build b/drivers/net/meson.build
>> index c7dae4ad273c..8d96244cdbb0 100644
>> --- a/drivers/net/meson.build
>> +++ b/drivers/net/meson.build
>> @@ -32,8 +32,8 @@ drivers = [
>> 'intel/ice',
>> 'intel/idpf',
>> 'intel/ipn3ke',
>> - 'intel/ixgbe',
>> 'intel/cpfl', # depends on idpf, so must come after it
>> + 'intel/ixgbe',
>> 'ionic',
>> 'mana',
>> 'memif',
>
> This is a strange one - did you do any investgation into why or how this
> fixes things? You describe it as a workaround so any hints towards a proper
> root cause and fix are welcome :-)
Hello Bruce,
This is indeed a bit puzzling: it seems that the expected ELF section is
present, a 'strings' dump shows no difference between a 'full' testpmd
and one missing ixgbe_vf. Still pmdinfo is missing one PMD.
The issue was not seen when using Ubuntu-24.04.
Best regards
Thierry
--
Thierry Herbelot
http://www.6wind.com/
Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [V2] drivers/net: reorder Intel drivers list in meson script
2026-01-23 16:57 ` Thierry Herbelot
@ 2026-02-16 10:48 ` Bruce Richardson
2026-02-16 11:32 ` Bruce Richardson
0 siblings, 1 reply; 14+ messages in thread
From: Bruce Richardson @ 2026-02-16 10:48 UTC (permalink / raw)
To: Thierry Herbelot
Cc: dev, Thomas Monjalon, Anatoly Burakov, stable, Olivier Matz
On Fri, Jan 23, 2026 at 05:57:41PM +0100, Thierry Herbelot wrote:
> On 1/23/26 17:50, Bruce Richardson wrote:
> > On Fri, Jan 23, 2026 at 05:27:07PM +0100, Thierry Herbelot wrote:
> > > After an upstream patch (see Fixes), net_ixgbe_vf is no longer
> > > declared in testpmd PMD info, when compiling under Redhat-9:
> > >
> > > > $ meson setup build && ninja -C build
> > > > $ ./usertools/dpdk-pmdinfo.py build/app/dpdk-testpmd|grep ixgbe
> > > > "name": "net_ixgbe",
> > >
> > > Name 'net_ixgbe_vf' should also be reported.
> > >
> > > One workaround is to move 'intel/ixgbe' as last in the list of Intel
> > > drivers. This restores net_ixgbe_vf under Redhat-9:
> > >
> > > > $ meson setup build && ninja -C build
> > > > $ ./usertools/dpdk-pmdinfo.py build/app/dpdk-testpmd|grep ixgbe
> > > > "name": "net_ixgbe_vf",
> > > > "name": "net_ixgbe",
> > >
> > > Fixes: 04f1b16c54f3 ("drivers: merge common and net idpf drivers")
> > > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > ---
> > > V2: use shorter lines in commit log.
> > > ---
> > > drivers/net/meson.build | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/meson.build b/drivers/net/meson.build
> > > index c7dae4ad273c..8d96244cdbb0 100644
> > > --- a/drivers/net/meson.build
> > > +++ b/drivers/net/meson.build
> > > @@ -32,8 +32,8 @@ drivers = [
> > > 'intel/ice',
> > > 'intel/idpf',
> > > 'intel/ipn3ke',
> > > - 'intel/ixgbe',
> > > 'intel/cpfl', # depends on idpf, so must come after it
> > > + 'intel/ixgbe',
> > > 'ionic',
> > > 'mana',
> > > 'memif',
> >
> > This is a strange one - did you do any investgation into why or how this
> > fixes things? You describe it as a workaround so any hints towards a proper
> > root cause and fix are welcome :-)
>
> Hello Bruce,
>
> This is indeed a bit puzzling: it seems that the expected ELF section is
> present, a 'strings' dump shows no difference between a 'full' testpmd and
> one missing ixgbe_vf. Still pmdinfo is missing one PMD.
>
> The issue was not seen when using Ubuntu-24.04.
>
[Not unexpectedly,] it appears that there is more to it than just missing
this driver. Installing a centos 9 VM and doing a clang build and comparing
the pmdinfo output to the GCC build output, I find there are in fact 3
missing drivers in the output: net_dpaa2, net_ixgbe_vf, and net_sfc_efx.
Changing the order of things to move down ixgbe makes ixgbe_vf and sfc_efx
reappear, but sadly net_vcpf now disappears. :-(
Therefore, more investigation and root causing is needed to find a proper
fix.
/Bruce
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [V2] drivers/net: reorder Intel drivers list in meson script
2026-02-16 10:48 ` Bruce Richardson
@ 2026-02-16 11:32 ` Bruce Richardson
2026-02-16 17:39 ` Thomas Monjalon
0 siblings, 1 reply; 14+ messages in thread
From: Bruce Richardson @ 2026-02-16 11:32 UTC (permalink / raw)
To: Thierry Herbelot
Cc: dev, Thomas Monjalon, Anatoly Burakov, stable, Olivier Matz,
david.marchand
On Mon, Feb 16, 2026 at 10:48:15AM +0000, Bruce Richardson wrote:
> On Fri, Jan 23, 2026 at 05:57:41PM +0100, Thierry Herbelot wrote:
> > On 1/23/26 17:50, Bruce Richardson wrote:
> > > On Fri, Jan 23, 2026 at 05:27:07PM +0100, Thierry Herbelot wrote:
> > > > After an upstream patch (see Fixes), net_ixgbe_vf is no longer
> > > > declared in testpmd PMD info, when compiling under Redhat-9:
> > > >
> > > > > $ meson setup build && ninja -C build
> > > > > $ ./usertools/dpdk-pmdinfo.py build/app/dpdk-testpmd|grep ixgbe
> > > > > "name": "net_ixgbe",
> > > >
> > > > Name 'net_ixgbe_vf' should also be reported.
> > > >
> > > > One workaround is to move 'intel/ixgbe' as last in the list of Intel
> > > > drivers. This restores net_ixgbe_vf under Redhat-9:
> > > >
> > > > > $ meson setup build && ninja -C build
> > > > > $ ./usertools/dpdk-pmdinfo.py build/app/dpdk-testpmd|grep ixgbe
> > > > > "name": "net_ixgbe_vf",
> > > > > "name": "net_ixgbe",
> > > >
> > > > Fixes: 04f1b16c54f3 ("drivers: merge common and net idpf drivers")
> > > > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > > ---
> > > > V2: use shorter lines in commit log.
> > > > ---
> > > > drivers/net/meson.build | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/net/meson.build b/drivers/net/meson.build
> > > > index c7dae4ad273c..8d96244cdbb0 100644
> > > > --- a/drivers/net/meson.build
> > > > +++ b/drivers/net/meson.build
> > > > @@ -32,8 +32,8 @@ drivers = [
> > > > 'intel/ice',
> > > > 'intel/idpf',
> > > > 'intel/ipn3ke',
> > > > - 'intel/ixgbe',
> > > > 'intel/cpfl', # depends on idpf, so must come after it
> > > > + 'intel/ixgbe',
> > > > 'ionic',
> > > > 'mana',
> > > > 'memif',
> > >
> > > This is a strange one - did you do any investgation into why or how this
> > > fixes things? You describe it as a workaround so any hints towards a proper
> > > root cause and fix are welcome :-)
> >
> > Hello Bruce,
> >
> > This is indeed a bit puzzling: it seems that the expected ELF section is
> > present, a 'strings' dump shows no difference between a 'full' testpmd and
> > one missing ixgbe_vf. Still pmdinfo is missing one PMD.
> >
> > The issue was not seen when using Ubuntu-24.04.
> >
> [Not unexpectedly,] it appears that there is more to it than just missing
> this driver. Installing a centos 9 VM and doing a clang build and comparing
> the pmdinfo output to the GCC build output, I find there are in fact 3
> missing drivers in the output: net_dpaa2, net_ixgbe_vf, and net_sfc_efx.
>
> Changing the order of things to move down ixgbe makes ixgbe_vf and sfc_efx
> reappear, but sadly net_vcpf now disappears. :-(
> Therefore, more investigation and root causing is needed to find a proper
> fix.
>
Doing a bit of poking with strings on the various binaries has shown why
some of these strings are not showing up despite being present in the
binary. In some cases, the bytes leading up to "PMD_INFO_STRING=" are
printable characters, in which case the PMD gets omitted from the output as
the ascii string found does not _start_ with PMD_INFO_STRING.
Given this info, I'm not sure whether this should be fixed in the code, is
a compiler issue, or whether we should just modify our script to find
PMD_INFO_STRING anywhere in output strings not just at the start.
Suggestions?
/Bruce
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [V2] drivers/net: reorder Intel drivers list in meson script
2026-02-16 11:32 ` Bruce Richardson
@ 2026-02-16 17:39 ` Thomas Monjalon
0 siblings, 0 replies; 14+ messages in thread
From: Thomas Monjalon @ 2026-02-16 17:39 UTC (permalink / raw)
To: Bruce Richardson
Cc: Thierry Herbelot, dev, Anatoly Burakov, stable, Olivier Matz,
david.marchand
16/02/2026 12:32, Bruce Richardson:
> On Mon, Feb 16, 2026 at 10:48:15AM +0000, Bruce Richardson wrote:
> > On Fri, Jan 23, 2026 at 05:57:41PM +0100, Thierry Herbelot wrote:
> > > On 1/23/26 17:50, Bruce Richardson wrote:
> > > > On Fri, Jan 23, 2026 at 05:27:07PM +0100, Thierry Herbelot wrote:
> > > > > After an upstream patch (see Fixes), net_ixgbe_vf is no longer
> > > > > declared in testpmd PMD info, when compiling under Redhat-9:
> > > > >
> > > > > > $ meson setup build && ninja -C build
> > > > > > $ ./usertools/dpdk-pmdinfo.py build/app/dpdk-testpmd|grep ixgbe
> > > > > > "name": "net_ixgbe",
> > > > >
> > > > > Name 'net_ixgbe_vf' should also be reported.
> > > > >
> > > > > One workaround is to move 'intel/ixgbe' as last in the list of Intel
> > > > > drivers. This restores net_ixgbe_vf under Redhat-9:
> > > > >
> > > > > > $ meson setup build && ninja -C build
> > > > > > $ ./usertools/dpdk-pmdinfo.py build/app/dpdk-testpmd|grep ixgbe
> > > > > > "name": "net_ixgbe_vf",
> > > > > > "name": "net_ixgbe",
> > > > >
> > > > > Fixes: 04f1b16c54f3 ("drivers: merge common and net idpf drivers")
> > > > > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > > > ---
> > > > > V2: use shorter lines in commit log.
> > > > > ---
> > > > > drivers/net/meson.build | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/drivers/net/meson.build b/drivers/net/meson.build
> > > > > index c7dae4ad273c..8d96244cdbb0 100644
> > > > > --- a/drivers/net/meson.build
> > > > > +++ b/drivers/net/meson.build
> > > > > @@ -32,8 +32,8 @@ drivers = [
> > > > > 'intel/ice',
> > > > > 'intel/idpf',
> > > > > 'intel/ipn3ke',
> > > > > - 'intel/ixgbe',
> > > > > 'intel/cpfl', # depends on idpf, so must come after it
> > > > > + 'intel/ixgbe',
> > > > > 'ionic',
> > > > > 'mana',
> > > > > 'memif',
> > > >
> > > > This is a strange one - did you do any investgation into why or how this
> > > > fixes things? You describe it as a workaround so any hints towards a proper
> > > > root cause and fix are welcome :-)
> > >
> > > Hello Bruce,
> > >
> > > This is indeed a bit puzzling: it seems that the expected ELF section is
> > > present, a 'strings' dump shows no difference between a 'full' testpmd and
> > > one missing ixgbe_vf. Still pmdinfo is missing one PMD.
> > >
> > > The issue was not seen when using Ubuntu-24.04.
> > >
> > [Not unexpectedly,] it appears that there is more to it than just missing
> > this driver. Installing a centos 9 VM and doing a clang build and comparing
> > the pmdinfo output to the GCC build output, I find there are in fact 3
> > missing drivers in the output: net_dpaa2, net_ixgbe_vf, and net_sfc_efx.
> >
> > Changing the order of things to move down ixgbe makes ixgbe_vf and sfc_efx
> > reappear, but sadly net_vcpf now disappears. :-(
> > Therefore, more investigation and root causing is needed to find a proper
> > fix.
> >
> Doing a bit of poking with strings on the various binaries has shown why
> some of these strings are not showing up despite being present in the
> binary. In some cases, the bytes leading up to "PMD_INFO_STRING=" are
> printable characters, in which case the PMD gets omitted from the output as
> the ascii string found does not _start_ with PMD_INFO_STRING.
>
> Given this info, I'm not sure whether this should be fixed in the code, is
> a compiler issue, or whether we should just modify our script to find
> PMD_INFO_STRING anywhere in output strings not just at the start.
>
> Suggestions?
I feel it would be more reliable to find the string anywhere.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] usertools/pmdinfo: fix search for PMD info string
2026-01-23 16:21 [PATCH] drivers/net: reorder Intel drivers list in meson script Thierry Herbelot
2026-01-23 16:27 ` [V2] " Thierry Herbelot
@ 2026-02-17 12:48 ` Bruce Richardson
2026-02-17 17:53 ` David Marchand
2026-02-18 9:41 ` Robin Jarry
1 sibling, 2 replies; 14+ messages in thread
From: Bruce Richardson @ 2026-02-17 12:48 UTC (permalink / raw)
To: dev; +Cc: thierry.herbelot, rjarry, Bruce Richardson, stable
The PMD_INFO_STRING constant string is not guaranteed to appear in the
output binary immediately after an unprintable character. Because of
this, in some cases the information for a driver could be missed by the
PMD info script as it only checks for the prefix at the start of strings
that it finds. Change the script to use "s.find()" rather than
"s.startswith()" to fix this issue.
Fixes: 0ce3cf4afd04 ("usertools/pmdinfo: rewrite simpler script")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
usertools/dpdk-pmdinfo.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py
index 9251c69db9..a4913f2209 100755
--- a/usertools/dpdk-pmdinfo.py
+++ b/usertools/dpdk-pmdinfo.py
@@ -221,8 +221,9 @@ def find_strings(buf: bytes, prefix: str) -> Iterator[str]:
if b == 0:
# end of string
s = view[start:i].tobytes().decode("ascii")
- if s.startswith(prefix):
- yield s[len(prefix) :]
+ idx = s.find(prefix)
+ if idx >= 0:
+ yield s[idx + len(prefix) :]
# There can be byte sequences where a non-printable byte
# follows a printable one. Ignore that.
start = None
--
2.51.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] usertools/pmdinfo: fix search for PMD info string
2026-02-17 12:48 ` [PATCH] usertools/pmdinfo: fix search for PMD info string Bruce Richardson
@ 2026-02-17 17:53 ` David Marchand
2026-02-17 17:59 ` Bruce Richardson
2026-02-18 9:41 ` Robin Jarry
1 sibling, 1 reply; 14+ messages in thread
From: David Marchand @ 2026-02-17 17:53 UTC (permalink / raw)
To: Bruce Richardson, thierry.herbelot; +Cc: dev, rjarry, stable
On Tue, 17 Feb 2026 at 13:49, Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> The PMD_INFO_STRING constant string is not guaranteed to appear in the
> output binary immediately after an unprintable character. Because of
> this, in some cases the information for a driver could be missed by the
> PMD info script as it only checks for the prefix at the start of strings
> that it finds. Change the script to use "s.find()" rather than
> "s.startswith()" to fix this issue.
>
> Fixes: 0ce3cf4afd04 ("usertools/pmdinfo: rewrite simpler script")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Surprising we hit this issue only now.
Acked-by: David Marchand <david.marchand@redhat.com>
It would be good to hear back from the initial reporter.
--
David Marchand
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] usertools/pmdinfo: fix search for PMD info string
2026-02-17 17:53 ` David Marchand
@ 2026-02-17 17:59 ` Bruce Richardson
2026-02-18 7:43 ` Thierry Herbelot
2026-02-18 8:38 ` David Marchand
0 siblings, 2 replies; 14+ messages in thread
From: Bruce Richardson @ 2026-02-17 17:59 UTC (permalink / raw)
To: David Marchand; +Cc: thierry.herbelot, dev, rjarry, stable
On Tue, Feb 17, 2026 at 06:53:20PM +0100, David Marchand wrote:
> On Tue, 17 Feb 2026 at 13:49, Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > The PMD_INFO_STRING constant string is not guaranteed to appear in the
> > output binary immediately after an unprintable character. Because of
> > this, in some cases the information for a driver could be missed by the
> > PMD info script as it only checks for the prefix at the start of strings
> > that it finds. Change the script to use "s.find()" rather than
> > "s.startswith()" to fix this issue.
> >
> > Fixes: 0ce3cf4afd04 ("usertools/pmdinfo: rewrite simpler script")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Surprising we hit this issue only now.
Agreed. Two thoughts here:
1. are the compilers normally arranging the data in ways that nearly
guarantee that the strings are not prefixed by other printable data?
2. if we were missing a couple of drivers from dpdk-pmdinfo, would it
really be noticed? Even in the reported case, there were actually 3 missing
driver listings, but only one was actually noticed.
I'd suspect #2 myself. :-)
> Acked-by: David Marchand <david.marchand@redhat.com>
>
> It would be good to hear back from the initial reporter.
>
Agreed. I'd like independent confirmation that this fixes the issue on RHEL
9 as reported.
/Bruce
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] usertools/pmdinfo: fix search for PMD info string
2026-02-17 17:59 ` Bruce Richardson
@ 2026-02-18 7:43 ` Thierry Herbelot
2026-02-18 8:38 ` David Marchand
1 sibling, 0 replies; 14+ messages in thread
From: Thierry Herbelot @ 2026-02-18 7:43 UTC (permalink / raw)
To: Bruce Richardson, David Marchand; +Cc: dev, rjarry, stable
On 2/17/26 18:59, Bruce Richardson wrote:
> On Tue, Feb 17, 2026 at 06:53:20PM +0100, David Marchand wrote:
>> On Tue, 17 Feb 2026 at 13:49, Bruce Richardson
>> <bruce.richardson@intel.com> wrote:
>>>
>>> The PMD_INFO_STRING constant string is not guaranteed to appear in the
>>> output binary immediately after an unprintable character. Because of
>>> this, in some cases the information for a driver could be missed by the
>>> PMD info script as it only checks for the prefix at the start of strings
>>> that it finds. Change the script to use "s.find()" rather than
>>> "s.startswith()" to fix this issue.
>>>
>>> Fixes: 0ce3cf4afd04 ("usertools/pmdinfo: rewrite simpler script")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>>
>> Surprising we hit this issue only now.
>
> Agreed. Two thoughts here:
> 1. are the compilers normally arranging the data in ways that nearly
> guarantee that the strings are not prefixed by other printable data?
> 2. if we were missing a couple of drivers from dpdk-pmdinfo, would it
> really be noticed? Even in the reported case, there were actually 3 missing
> driver listings, but only one was actually noticed.
>
> I'd suspect #2 myself. :-)
>
>> Acked-by: David Marchand <david.marchand@redhat.com>
>>
>> It would be good to hear back from the initial reporter.
>>
> Agreed. I'd like independent confirmation that this fixes the issue on RHEL
> 9 as reported.
Hello Bruce,
Sorry for the late response.
I confirm your patch does fix the original issue:
$ head -2 /etc/os-release
NAME="Red Hat Enterprise Linux"
VERSION="9.7 (Plow)"
$ meson setup build
$ ninja -C build
...
$ ./usertools/dpdk-pmdinfo.py build/app/dpdk-testpmd|grep ixgbe
"name": "net_ixgbe_vf",
"name": "net_ixgbe",
Thanks !
Best regards
Thierry
>
> /Bruce
--
Thierry Herbelot
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] usertools/pmdinfo: fix search for PMD info string
2026-02-17 17:59 ` Bruce Richardson
2026-02-18 7:43 ` Thierry Herbelot
@ 2026-02-18 8:38 ` David Marchand
1 sibling, 0 replies; 14+ messages in thread
From: David Marchand @ 2026-02-18 8:38 UTC (permalink / raw)
To: Bruce Richardson; +Cc: thierry.herbelot, dev, rjarry, stable
On Tue, 17 Feb 2026 at 19:00, Bruce Richardson
<bruce.richardson@intel.com> wrote:
> > Surprising we hit this issue only now.
>
> Agreed. Two thoughts here:
> 1. are the compilers normally arranging the data in ways that nearly
> guarantee that the strings are not prefixed by other printable data?
> 2. if we were missing a couple of drivers from dpdk-pmdinfo, would it
> really be noticed? Even in the reported case, there were actually 3 missing
> driver listings, but only one was actually noticed.
>
> I'd suspect #2 myself. :-)
Yeah, the latter is likely.
Thanks Bruce.
--
David Marchand
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] usertools/pmdinfo: fix search for PMD info string
2026-02-17 12:48 ` [PATCH] usertools/pmdinfo: fix search for PMD info string Bruce Richardson
2026-02-17 17:53 ` David Marchand
@ 2026-02-18 9:41 ` Robin Jarry
2026-03-17 13:57 ` Thomas Monjalon
1 sibling, 1 reply; 14+ messages in thread
From: Robin Jarry @ 2026-02-18 9:41 UTC (permalink / raw)
To: Bruce Richardson, dev; +Cc: thierry.herbelot, stable
Bruce Richardson, Feb 17, 2026 at 13:48:
> The PMD_INFO_STRING constant string is not guaranteed to appear in the
> output binary immediately after an unprintable character. Because of
> this, in some cases the information for a driver could be missed by the
> PMD info script as it only checks for the prefix at the start of strings
> that it finds. Change the script to use "s.find()" rather than
> "s.startswith()" to fix this issue.
>
> Fixes: 0ce3cf4afd04 ("usertools/pmdinfo: rewrite simpler script")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Nice find. Thanks Bruce.
Acked-by: Robin Jarry <rjarry@redhat.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] usertools/pmdinfo: fix search for PMD info string
2026-02-18 9:41 ` Robin Jarry
@ 2026-03-17 13:57 ` Thomas Monjalon
0 siblings, 0 replies; 14+ messages in thread
From: Thomas Monjalon @ 2026-03-17 13:57 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, thierry.herbelot, stable, Robin Jarry
18/02/2026 10:41, Robin Jarry:
> Bruce Richardson, Feb 17, 2026 at 13:48:
> > The PMD_INFO_STRING constant string is not guaranteed to appear in the
> > output binary immediately after an unprintable character. Because of
> > this, in some cases the information for a driver could be missed by the
> > PMD info script as it only checks for the prefix at the start of strings
> > that it finds. Change the script to use "s.find()" rather than
> > "s.startswith()" to fix this issue.
> >
> > Fixes: 0ce3cf4afd04 ("usertools/pmdinfo: rewrite simpler script")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Nice find. Thanks Bruce.
>
> Acked-by: Robin Jarry <rjarry@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2026-03-17 13:57 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-23 16:21 [PATCH] drivers/net: reorder Intel drivers list in meson script Thierry Herbelot
2026-01-23 16:27 ` [V2] " Thierry Herbelot
2026-01-23 16:50 ` Bruce Richardson
2026-01-23 16:57 ` Thierry Herbelot
2026-02-16 10:48 ` Bruce Richardson
2026-02-16 11:32 ` Bruce Richardson
2026-02-16 17:39 ` Thomas Monjalon
2026-02-17 12:48 ` [PATCH] usertools/pmdinfo: fix search for PMD info string Bruce Richardson
2026-02-17 17:53 ` David Marchand
2026-02-17 17:59 ` Bruce Richardson
2026-02-18 7:43 ` Thierry Herbelot
2026-02-18 8:38 ` David Marchand
2026-02-18 9:41 ` Robin Jarry
2026-03-17 13:57 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox