From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marko Kovacevic <marko.kovacevic@intel.com>
Subject: Re: [PATCH v5 2/8] examples/cryptodev_fips_validate: add
 aes parser and enablement for test types
Date: Wed, 24 Oct 2018 15:18:12 +0100
Message-ID: <8280df23-7cde-668c-2176-a787daabd457@intel.com>
References: <20181012144501.19562-1-marko.kovacevic@intel.com>
 <20181017124937.38052-1-marko.kovacevic@intel.com>
 <20181017124937.38052-3-marko.kovacevic@intel.com>
 <aa7f8395-a4a8-1844-a0c9-a29ae7ab03f6@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "roy.fan.zhang@intel.com" <roy.fan.zhang@intel.com>,
 "arkadiuszx.kusztal@intel.com" <arkadiuszx.kusztal@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id B01A62B94
 for <dev@dpdk.org>; Wed, 24 Oct 2018 16:18:15 +0200 (CEST)
In-Reply-To: <aa7f8395-a4a8-1844-a0c9-a29ae7ab03f6@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 24/10/2018 13:37, Akhil Goyal wrote:
>
> On 10/17/2018 6:19 PM, Marko Kovacevic wrote:
>> diff --git a/examples/cryptodev_fips_validate/cryptodev_fips_validate.h b/examples/cryptodev_fips_validate/cryptodev_fips_validate.h
>> index beb6bed..5ac858d 100644
>> --- a/examples/cryptodev_fips_validate/cryptodev_fips_validate.h
>> +++ b/examples/cryptodev_fips_validate/cryptodev_fips_validate.h
>> @@ -23,6 +23,7 @@
>>    #define FAX_FILE_PERFIX		"fax"
>>    
>>    enum fips_test_algorithms {
>> +		FIPS_TEST_ALGO_AES = 0,
>>    		FIPS_TEST_ALGO_MAX
>>    };
>>    
>> @@ -77,6 +78,21 @@ struct fips_test_callback {
>>    	struct fips_val *val;
>>    };
>>    
>> +enum fips_aesavs_test_types {
>> +	AESAVS_TYPE_GFXBOX = 0,
>> +	AESAVS_TYPE_KEYSBOX,
>> +	AESAVS_TYPE_VARKEY,
>> +	AESAVS_TYPE_VARTXT,
>> +	AESAVS_TYPE_MMT,
>> +	AESAVS_TYPE_MCT,
>> +};
> It would be better to start the enums from 1. Consider a case when an
> uninitialized/unsupported type is accidentally used and it would be
> treated as AES and would be processed accordingly.
sure ill change that