From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3] kni: fix compilation issue in KNI vhost
	on kernel 3.19/4.0
Date: Sun, 10 May 2015 23:25:38 +0200
Message-ID: <8281433.nBqoHGD3WT@xps13>
References: <1430829319-22242-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1430834880-14482-1-git-send-email-pablo.de.lara.guarch@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com
 [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id AF986C38E
 for <dev@dpdk.org>; Sun, 10 May 2015 23:26:20 +0200 (CEST)
Received: by wizk4 with SMTP id k4so84284854wiz.1
 for <dev@dpdk.org>; Sun, 10 May 2015 14:26:20 -0700 (PDT)
In-Reply-To: <1430834880-14482-1-git-send-email-pablo.de.lara.guarch@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Pablo,

2015-05-05 15:08, Pablo de Lara:
> Due to commit c0371da6 in kernel 3.19, which removed msg_iov
> and msg_iovlen from struct msghdr, DPDK would not build.
> Also, functions memcpy_toiovecend and memcpy_fromiovecend
> were removed in commits ba7438ae and 57dd8a07, being substituted by
> copy_from_iter and copy_to_iter.
>=20
> This patch makes use of struct iov_iter, which has references
> to msg_iov and msg_iovln, and makes use of copy_from_iter
> and copy_to_iter.
>=20
> Changes in v2:
> - Replaced functions memcpy_toiovecend and memcpy_fromiovecend
>   with copy_from_iter and copy_to_iter
>=20
> Changes in v3:
> - Fixed variable names
> - Add missing checks
>=20
> Reported-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

I have the following errors with Linux 4.0.1:

lib/librte_eal/linuxapp/kni/igb_main.c:2321:2: error: initialization fr=
om incompatible pointer type
  .ndo_bridge_setlink =3D igb_ndo_bridge_setlink,
  ^
lib/librte_eal/linuxapp/kni/igb_main.c:2321:2: error: (near initializat=
ion for =E2=80=98igb_netdev_ops.ndo_bridge_setlink=E2=80=99)
lib/librte_eal/linuxapp/kni/igb_main.c: In function =E2=80=98igb_xmit_f=
rame_ring=E2=80=99:
lib/librte_eal/linuxapp/kni/igb_main.c:5482:2: error: implicit declarat=
ion of function =E2=80=98vlan_tx_tag_present=E2=80=99
  if (vlan_tx_tag_present(skb)) {
  ^
lib/librte_eal/linuxapp/kni/igb_main.c:5484:3: error: implicit declarat=
ion of function =E2=80=98vlan_tx_tag_get=E2=80=99
   tx_flags |=3D (vlan_tx_tag_get(skb) << IGB_TX_FLAGS_VLAN_SHIFT);
   ^