From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2] net/bond: change link status check to no-wait Date: Thu, 29 Jun 2017 12:34:25 +0100 Message-ID: <82e36fac-072e-f0d2-6816-d4510d7778b4@intel.com> References: <20170626151347.16680-1-declan.doherty@intel.com> <20170628101550.24643-1-declan.doherty@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Declan Doherty , dev@dpdk.org Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 60C662904 for ; Thu, 29 Jun 2017 13:34:28 +0200 (CEST) In-Reply-To: <20170628101550.24643-1-declan.doherty@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/28/2017 11:15 AM, Declan Doherty wrote: > In 2 modes (802.3ad and TLB) of the link bonding driver, monitoring of > link status is used to determine the active slaves to use. These > functions are currently using the rte_link_link_get which could block > for up to 9 seconds, depending on the slave device. > > In the 802.3ad periodic callback and in the TLB slave callback the > link status of slaves are checked using rte_eth_link_get function. > > This patch changes to the no-wait version of the link get function to > avoid the possible issues which could be introduced if this call was > to block for an extended period of time. Fixes: 46fb43683679 ("bond: add mode 4") Fixes: 7c76a747e68c ("bond: add mode 5") Cc: stable@dpdk.org > > Signed-off-by: Declan Doherty Applied to dpdk-next-net/master, thanks.