* [PATCH] Pass CC option when building kernel modules
@ 2014-10-06 15:57 Sergio Gonzalez Monroy
[not found] ` <1412611022-8278-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 8+ messages in thread
From: Sergio Gonzalez Monroy @ 2014-10-06 15:57 UTC (permalink / raw)
To: dev-VfR2kkLFssw
At least on kernels 3.15 or newer, DPDK build is broken for CLANG target.
The issue is that the kernel build system sets the flags before including
DPDK makefile and therefore assumes the incorrect compiler.
Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
mk/rte.module.mk | 2 +-
mk/target/generic/rte.vars.mk | 2 ++
mk/toolchain/clang/rte.vars.mk | 5 +----
mk/toolchain/gcc/rte.vars.mk | 1 +
mk/toolchain/icc/rte.vars.mk | 5 +----
5 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/mk/rte.module.mk b/mk/rte.module.mk
index c4ca3fd..41c0d0f 100644
--- a/mk/rte.module.mk
+++ b/mk/rte.module.mk
@@ -78,7 +78,7 @@ build: _postbuild
$(MODULE).ko: $(SRCS_LINKS)
@if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi
@$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \
- CROSS_COMPILE=$(CROSS)
+ CC=$(KERNELCC) CROSS_COMPILE=$(CROSS)
# install module in $(RTE_OUTPUT)/kmod
$(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko
diff --git a/mk/target/generic/rte.vars.mk b/mk/target/generic/rte.vars.mk
index 6020f20..74ff771 100644
--- a/mk/target/generic/rte.vars.mk
+++ b/mk/target/generic/rte.vars.mk
@@ -149,4 +149,6 @@ endif
export CFLAGS
export LDFLAGS
+else # ! ifeq ($(KERNELRELEASE),)
+CC = $(KERNELCC)
endif
diff --git a/mk/toolchain/clang/rte.vars.mk b/mk/toolchain/clang/rte.vars.mk
index ee4f451..40cb389 100644
--- a/mk/toolchain/clang/rte.vars.mk
+++ b/mk/toolchain/clang/rte.vars.mk
@@ -38,11 +38,8 @@
# - define TOOLCHAIN_ASFLAGS variable (overriden by cmdline value)
#
-ifeq ($(KERNELRELEASE),)
CC = $(CROSS)clang
-else
-CC = $(CROSS)gcc
-endif
+KERNELCC = $(CROSS)gcc
CPP = $(CROSS)cpp
# for now, we don't use as but nasm.
# AS = $(CROSS)as
diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk
index 262ebdf..993eb26 100644
--- a/mk/toolchain/gcc/rte.vars.mk
+++ b/mk/toolchain/gcc/rte.vars.mk
@@ -39,6 +39,7 @@
#
CC = $(CROSS)gcc
+KERNELCC = $(CROSS)gcc
CPP = $(CROSS)cpp
# for now, we don't use as but nasm.
# AS = $(CROSS)as
diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk
index 612370d..f03a2a2 100644
--- a/mk/toolchain/icc/rte.vars.mk
+++ b/mk/toolchain/icc/rte.vars.mk
@@ -41,11 +41,8 @@
# Warning: we do not use CROSS environment variable as icc is mainly a
# x86->x86 compiler
-ifeq ($(KERNELRELEASE),)
CC = icc
-else
-CC = gcc
-endif
+KERNELCC = gcc
CPP = cpp
AS = nasm
AR = ar
--
1.9.3
^ permalink raw reply related [flat|nested] 8+ messages in thread[parent not found: <1412611022-8278-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] Pass CC option when building kernel modules [not found] ` <1412611022-8278-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> @ 2014-10-06 16:12 ` Bruce Richardson 2014-10-08 17:15 ` Thomas Monjalon 2014-10-09 10:08 ` [PATCH v2] " Sergio Gonzalez Monroy 2 siblings, 0 replies; 8+ messages in thread From: Bruce Richardson @ 2014-10-06 16:12 UTC (permalink / raw) To: Sergio Gonzalez Monroy; +Cc: dev-VfR2kkLFssw On Mon, Oct 06, 2014 at 04:57:02PM +0100, Sergio Gonzalez Monroy wrote: > At least on kernels 3.15 or newer, DPDK build is broken for CLANG target. > The issue is that the kernel build system sets the flags before including > DPDK makefile and therefore assumes the incorrect compiler. > > Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> I can confirm that this patch fixes the clang compile for me on Fedora 20 with kernel 3.16.3-200.fc20.x86_64. Acked-by: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > --- > mk/rte.module.mk | 2 +- > mk/target/generic/rte.vars.mk | 2 ++ > mk/toolchain/clang/rte.vars.mk | 5 +---- > mk/toolchain/gcc/rte.vars.mk | 1 + > mk/toolchain/icc/rte.vars.mk | 5 +---- > 5 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/mk/rte.module.mk b/mk/rte.module.mk > index c4ca3fd..41c0d0f 100644 > --- a/mk/rte.module.mk > +++ b/mk/rte.module.mk > @@ -78,7 +78,7 @@ build: _postbuild > $(MODULE).ko: $(SRCS_LINKS) > @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \ > - CROSS_COMPILE=$(CROSS) > + CC=$(KERNELCC) CROSS_COMPILE=$(CROSS) > > # install module in $(RTE_OUTPUT)/kmod > $(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko > diff --git a/mk/target/generic/rte.vars.mk b/mk/target/generic/rte.vars.mk > index 6020f20..74ff771 100644 > --- a/mk/target/generic/rte.vars.mk > +++ b/mk/target/generic/rte.vars.mk > @@ -149,4 +149,6 @@ endif > export CFLAGS > export LDFLAGS > > +else # ! ifeq ($(KERNELRELEASE),) > +CC = $(KERNELCC) > endif > diff --git a/mk/toolchain/clang/rte.vars.mk b/mk/toolchain/clang/rte.vars.mk > index ee4f451..40cb389 100644 > --- a/mk/toolchain/clang/rte.vars.mk > +++ b/mk/toolchain/clang/rte.vars.mk > @@ -38,11 +38,8 @@ > # - define TOOLCHAIN_ASFLAGS variable (overriden by cmdline value) > # > > -ifeq ($(KERNELRELEASE),) > CC = $(CROSS)clang > -else > -CC = $(CROSS)gcc > -endif > +KERNELCC = $(CROSS)gcc > CPP = $(CROSS)cpp > # for now, we don't use as but nasm. > # AS = $(CROSS)as > diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk > index 262ebdf..993eb26 100644 > --- a/mk/toolchain/gcc/rte.vars.mk > +++ b/mk/toolchain/gcc/rte.vars.mk > @@ -39,6 +39,7 @@ > # > > CC = $(CROSS)gcc > +KERNELCC = $(CROSS)gcc > CPP = $(CROSS)cpp > # for now, we don't use as but nasm. > # AS = $(CROSS)as > diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk > index 612370d..f03a2a2 100644 > --- a/mk/toolchain/icc/rte.vars.mk > +++ b/mk/toolchain/icc/rte.vars.mk > @@ -41,11 +41,8 @@ > # Warning: we do not use CROSS environment variable as icc is mainly a > # x86->x86 compiler > > -ifeq ($(KERNELRELEASE),) > CC = icc > -else > -CC = gcc > -endif > +KERNELCC = gcc > CPP = cpp > AS = nasm > AR = ar > -- > 1.9.3 > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Pass CC option when building kernel modules [not found] ` <1412611022-8278-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2014-10-06 16:12 ` Bruce Richardson @ 2014-10-08 17:15 ` Thomas Monjalon 2014-10-09 8:10 ` Bruce Richardson 2014-10-09 10:08 ` [PATCH v2] " Sergio Gonzalez Monroy 2 siblings, 1 reply; 8+ messages in thread From: Thomas Monjalon @ 2014-10-08 17:15 UTC (permalink / raw) To: Sergio Gonzalez Monroy; +Cc: dev-VfR2kkLFssw 2014-10-06 16:57, Sergio Gonzalez Monroy: > At least on kernels 3.15 or newer, DPDK build is broken for CLANG target. > The issue is that the kernel build system sets the flags before including > DPDK makefile and therefore assumes the incorrect compiler. > > Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > --- a/mk/rte.module.mk > +++ b/mk/rte.module.mk > @@ -78,7 +78,7 @@ build: _postbuild > $(MODULE).ko: $(SRCS_LINKS) > @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \ > - CROSS_COMPILE=$(CROSS) > + CC=$(KERNELCC) CROSS_COMPILE=$(CROSS) > --- a/mk/target/generic/rte.vars.mk > +++ b/mk/target/generic/rte.vars.mk > @@ -149,4 +149,6 @@ endif > export CFLAGS > export LDFLAGS > > +else # ! ifeq ($(KERNELRELEASE),) > +CC = $(KERNELCC) > endif Why is it needed here? Setting CC in rte.module.mk is not sufficient? Thanks -- Thomas ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Pass CC option when building kernel modules 2014-10-08 17:15 ` Thomas Monjalon @ 2014-10-09 8:10 ` Bruce Richardson 2014-10-09 10:04 ` Sergio Gonzalez Monroy 0 siblings, 1 reply; 8+ messages in thread From: Bruce Richardson @ 2014-10-09 8:10 UTC (permalink / raw) To: Thomas Monjalon; +Cc: dev-VfR2kkLFssw On Wed, Oct 08, 2014 at 07:15:04PM +0200, Thomas Monjalon wrote: > 2014-10-06 16:57, Sergio Gonzalez Monroy: > > At least on kernels 3.15 or newer, DPDK build is broken for CLANG target. > > The issue is that the kernel build system sets the flags before including > > DPDK makefile and therefore assumes the incorrect compiler. > > > > Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > > > --- a/mk/rte.module.mk > > +++ b/mk/rte.module.mk > > @@ -78,7 +78,7 @@ build: _postbuild > > $(MODULE).ko: $(SRCS_LINKS) > > @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > > @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \ > > - CROSS_COMPILE=$(CROSS) > > + CC=$(KERNELCC) CROSS_COMPILE=$(CROSS) > > > --- a/mk/target/generic/rte.vars.mk > > +++ b/mk/target/generic/rte.vars.mk > > @@ -149,4 +149,6 @@ endif > > export CFLAGS > > export LDFLAGS > > > > +else # ! ifeq ($(KERNELRELEASE),) > > +CC = $(KERNELCC) > > endif > > Why is it needed here? Setting CC in rte.module.mk is not sufficient? > Right now, no it's not, and that's what is causing the error. However, we maybe can look and see if we moved the definition in rte.module.mk we might get the same effect. /Bruce > Thanks > -- > Thomas ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Pass CC option when building kernel modules 2014-10-09 8:10 ` Bruce Richardson @ 2014-10-09 10:04 ` Sergio Gonzalez Monroy 0 siblings, 0 replies; 8+ messages in thread From: Sergio Gonzalez Monroy @ 2014-10-09 10:04 UTC (permalink / raw) To: Bruce Richardson; +Cc: dev-VfR2kkLFssw On Thu, Oct 09, 2014 at 09:10:04AM +0100, Bruce Richardson wrote: > On Wed, Oct 08, 2014 at 07:15:04PM +0200, Thomas Monjalon wrote: > > 2014-10-06 16:57, Sergio Gonzalez Monroy: > > > At least on kernels 3.15 or newer, DPDK build is broken for CLANG target. > > > The issue is that the kernel build system sets the flags before including > > > DPDK makefile and therefore assumes the incorrect compiler. > > > > > > Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > > > > > --- a/mk/rte.module.mk > > > +++ b/mk/rte.module.mk > > > @@ -78,7 +78,7 @@ build: _postbuild > > > $(MODULE).ko: $(SRCS_LINKS) > > > @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > > > @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \ > > > - CROSS_COMPILE=$(CROSS) > > > + CC=$(KERNELCC) CROSS_COMPILE=$(CROSS) > > > > > --- a/mk/target/generic/rte.vars.mk > > > +++ b/mk/target/generic/rte.vars.mk > > > @@ -149,4 +149,6 @@ endif > > > export CFLAGS > > > export LDFLAGS > > > > > > +else # ! ifeq ($(KERNELRELEASE),) > > > +CC = $(KERNELCC) > > > endif > > > > Why is it needed here? Setting CC in rte.module.mk is not sufficient? > > > Right now, no it's not, and that's what is causing the error. However, we > maybe can look and see if we moved the definition in rte.module.mk we might > get the same effect. > I just did a bit more testing and it seems like it is not necessary to reset CC, CC set from the command line takes precedence. I will post a v2 with the fix. Thanks, Sergio > /Bruce > > > Thanks > > -- > > Thomas ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] Pass CC option when building kernel modules [not found] ` <1412611022-8278-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2014-10-06 16:12 ` Bruce Richardson 2014-10-08 17:15 ` Thomas Monjalon @ 2014-10-09 10:08 ` Sergio Gonzalez Monroy [not found] ` <1412849313-5958-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2 siblings, 1 reply; 8+ messages in thread From: Sergio Gonzalez Monroy @ 2014-10-09 10:08 UTC (permalink / raw) To: dev-VfR2kkLFssw At least on kernels 3.15 or newer, wrong compiler flags are set when building kernel modules. v2: Remove unnecessary reset of CC when being included from the kernel. Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> --- mk/rte.module.mk | 2 +- mk/toolchain/clang/rte.vars.mk | 5 +---- mk/toolchain/gcc/rte.vars.mk | 1 + mk/toolchain/icc/rte.vars.mk | 5 +---- 4 files changed, 4 insertions(+), 9 deletions(-) diff --git a/mk/rte.module.mk b/mk/rte.module.mk index c4ca3fd..41c0d0f 100644 --- a/mk/rte.module.mk +++ b/mk/rte.module.mk @@ -78,7 +78,7 @@ build: _postbuild $(MODULE).ko: $(SRCS_LINKS) @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \ - CROSS_COMPILE=$(CROSS) + CC=$(KERNELCC) CROSS_COMPILE=$(CROSS) # install module in $(RTE_OUTPUT)/kmod $(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko diff --git a/mk/toolchain/clang/rte.vars.mk b/mk/toolchain/clang/rte.vars.mk index ee4f451..40cb389 100644 --- a/mk/toolchain/clang/rte.vars.mk +++ b/mk/toolchain/clang/rte.vars.mk @@ -38,11 +38,8 @@ # - define TOOLCHAIN_ASFLAGS variable (overriden by cmdline value) # -ifeq ($(KERNELRELEASE),) CC = $(CROSS)clang -else -CC = $(CROSS)gcc -endif +KERNELCC = $(CROSS)gcc CPP = $(CROSS)cpp # for now, we don't use as but nasm. # AS = $(CROSS)as diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk index 262ebdf..993eb26 100644 --- a/mk/toolchain/gcc/rte.vars.mk +++ b/mk/toolchain/gcc/rte.vars.mk @@ -39,6 +39,7 @@ # CC = $(CROSS)gcc +KERNELCC = $(CROSS)gcc CPP = $(CROSS)cpp # for now, we don't use as but nasm. # AS = $(CROSS)as diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk index 612370d..f03a2a2 100644 --- a/mk/toolchain/icc/rte.vars.mk +++ b/mk/toolchain/icc/rte.vars.mk @@ -41,11 +41,8 @@ # Warning: we do not use CROSS environment variable as icc is mainly a # x86->x86 compiler -ifeq ($(KERNELRELEASE),) CC = icc -else -CC = gcc -endif +KERNELCC = gcc CPP = cpp AS = nasm AR = ar -- 1.9.3 ^ permalink raw reply related [flat|nested] 8+ messages in thread
[parent not found: <1412849313-5958-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH v2] Pass CC option when building kernel modules [not found] ` <1412849313-5958-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> @ 2014-10-13 16:08 ` De Lara Guarch, Pablo [not found] ` <E115CCD9D858EF4F90C690B0DCB4D8972262B7F2-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org> 0 siblings, 1 reply; 8+ messages in thread From: De Lara Guarch, Pablo @ 2014-10-13 16:08 UTC (permalink / raw) To: Gonzalez Monroy, Sergio, dev-VfR2kkLFssw@public.gmane.org > -----Original Message----- > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Thursday, October 09, 2014 11:09 AM > To: dev-VfR2kkLFssw@public.gmane.org > Subject: [dpdk-dev] [PATCH v2] Pass CC option when building kernel > modules > > At least on kernels 3.15 or newer, wrong compiler flags are set when building > kernel modules. > > v2: > Remove unnecessary reset of CC when being included from the kernel. > > Signed-off-by: Sergio Gonzalez Monroy > <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Acked-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > --- > mk/rte.module.mk | 2 +- > mk/toolchain/clang/rte.vars.mk | 5 +---- > mk/toolchain/gcc/rte.vars.mk | 1 + > mk/toolchain/icc/rte.vars.mk | 5 +---- > 4 files changed, 4 insertions(+), 9 deletions(-) > > diff --git a/mk/rte.module.mk b/mk/rte.module.mk > index c4ca3fd..41c0d0f 100644 > --- a/mk/rte.module.mk > +++ b/mk/rte.module.mk > @@ -78,7 +78,7 @@ build: _postbuild > $(MODULE).ko: $(SRCS_LINKS) > @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) > O=$(RTE_KERNELDIR) \ > - CROSS_COMPILE=$(CROSS) > + CC=$(KERNELCC) CROSS_COMPILE=$(CROSS) > > # install module in $(RTE_OUTPUT)/kmod > $(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko > diff --git a/mk/toolchain/clang/rte.vars.mk b/mk/toolchain/clang/rte.vars.mk > index ee4f451..40cb389 100644 > --- a/mk/toolchain/clang/rte.vars.mk > +++ b/mk/toolchain/clang/rte.vars.mk > @@ -38,11 +38,8 @@ > # - define TOOLCHAIN_ASFLAGS variable (overriden by cmdline value) > # > > -ifeq ($(KERNELRELEASE),) > CC = $(CROSS)clang > -else > -CC = $(CROSS)gcc > -endif > +KERNELCC = $(CROSS)gcc > CPP = $(CROSS)cpp > # for now, we don't use as but nasm. > # AS = $(CROSS)as > diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk > index 262ebdf..993eb26 100644 > --- a/mk/toolchain/gcc/rte.vars.mk > +++ b/mk/toolchain/gcc/rte.vars.mk > @@ -39,6 +39,7 @@ > # > > CC = $(CROSS)gcc > +KERNELCC = $(CROSS)gcc > CPP = $(CROSS)cpp > # for now, we don't use as but nasm. > # AS = $(CROSS)as > diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk > index 612370d..f03a2a2 100644 > --- a/mk/toolchain/icc/rte.vars.mk > +++ b/mk/toolchain/icc/rte.vars.mk > @@ -41,11 +41,8 @@ > # Warning: we do not use CROSS environment variable as icc is mainly a > # x86->x86 compiler > > -ifeq ($(KERNELRELEASE),) > CC = icc > -else > -CC = gcc > -endif > +KERNELCC = gcc > CPP = cpp > AS = nasm > AR = ar > -- > 1.9.3 ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <E115CCD9D858EF4F90C690B0DCB4D8972262B7F2-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>]
* Re: [PATCH v2] Pass CC option when building kernel modules [not found] ` <E115CCD9D858EF4F90C690B0DCB4D8972262B7F2-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org> @ 2014-10-15 14:03 ` Thomas Monjalon 0 siblings, 0 replies; 8+ messages in thread From: Thomas Monjalon @ 2014-10-15 14:03 UTC (permalink / raw) To: Gonzalez Monroy, Sergio; +Cc: dev-VfR2kkLFssw > > At least on kernels 3.15 or newer, wrong compiler flags are set when building > > kernel modules. > > > > v2: > > Remove unnecessary reset of CC when being included from the kernel. > > > > Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > > Acked-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Applied Thanks -- Thomas ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-10-15 14:03 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-06 15:57 [PATCH] Pass CC option when building kernel modules Sergio Gonzalez Monroy
[not found] ` <1412611022-8278-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-06 16:12 ` Bruce Richardson
2014-10-08 17:15 ` Thomas Monjalon
2014-10-09 8:10 ` Bruce Richardson
2014-10-09 10:04 ` Sergio Gonzalez Monroy
2014-10-09 10:08 ` [PATCH v2] " Sergio Gonzalez Monroy
[not found] ` <1412849313-5958-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-13 16:08 ` De Lara Guarch, Pablo
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D8972262B7F2-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-15 14:03 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).