From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dharmik Thakkar <Dharmik.Thakkar@arm.com>
Subject: Re: [PATCH v4 2/2] test/hash: lock-free rw concurrency
 test ext bkt
Date: Tue, 2 Apr 2019 19:44:27 +0000
Message-ID: <83121B26-F2A5-4342-ADE1-E77651808A59@arm.com>
References: <20190401221836.16599-1-dharmik.thakkar@arm.com>
 <20190401230830.17931-1-dharmik.thakkar@arm.com>
 <20190401230830.17931-3-dharmik.thakkar@arm.com> <2434371.7uYfYzBtHE@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, Yipeng Wang <yipeng1.wang@intel.com>, Sameh
 Gobriel <sameh.gobriel@intel.com>, Bruce Richardson
 <bruce.richardson@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, nd <nd@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr50050.outbound.protection.outlook.com [40.107.5.50])
 by dpdk.org (Postfix) with ESMTP id AACB67D52
 for <dev@dpdk.org>; Tue,  2 Apr 2019 21:44:29 +0200 (CEST)
In-Reply-To: <2434371.7uYfYzBtHE@xps>
Content-Language: en-US
Content-ID: <8DD09FD39CC64941B3B0A78F3D2D7478@eurprd08.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Thomas,

Thank you for the review!

> On Apr 1, 2019, at 7:57 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
>=20
> 02/04/2019 01:08, Dharmik Thakkar:
>> Add unit test to check for hash lookup and bulk-lookup perf for
>> extendable bucket feature.
>> It is tested with both lock-free enabled and lock-free disabled case.
>>=20
>> Test includes:
>>=20
>> - hash lookup on keys in ext bkt
>> - hash delete causing key-shifts of keys from ext bkt to secondary bkt
>>=20
>> Suggested-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>> Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
>> Acked-by: Yipeng Wang <yipeng1.wang@intel.com>
>> ---
>> v4:
>> - Add Acked-by tag.
>=20
> FYI, no need to send a new version just for this.
Sure, thanks!
>=20
> Please run devtools/test-meson-builds.sh.
> When building build-clang-static, I see this error:
>=20
> app/test/test_hash_readwrite_lf.c:670:13: error:
> variable 'key_cnt' is used uninitialized whenever 'if' condition is false
Will resolve and update.