From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v8 03/11] net/failsafe: add fail-safe PMD Date: Wed, 12 Jul 2017 00:21:24 +0200 Message-ID: <83323603.jg1xmzcquq@xps> References: <6696281.voRgjYsRM1@xps> <20170711214819.GZ11154@bidouze.vm.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 420E22C54 for ; Wed, 12 Jul 2017 00:21:26 +0200 (CEST) In-Reply-To: <20170711214819.GZ11154@bidouze.vm.6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/07/2017 23:48, Ga=EBtan Rivet: > On Tue, Jul 11, 2017 at 09:57:51PM +0200, Thomas Monjalon wrote: > > 11/07/2017 01:19, Gaetan Rivet: > > > --- /dev/null > > > +++ b/drivers/net/failsafe/failsafe_args.c > > [...] > > > +#include > >=20 > > Do you really need errno in this file? >=20 > It's used for error handling on strtoull and popen. > Why, is it a problem to include errno.h? I don't see errno used in this patch. I think it is used in next patches.