From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] ethdev: remove experimental flag of ports
 enumeration
Date: Wed, 25 Apr 2018 11:21:43 +0100
Message-ID: <8341c868-bab3-44b7-a870-bc07af9828db@intel.com>
References: <20180424021511.17430-1-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id CAAD12C0C
 for <dev@dpdk.org>; Wed, 25 Apr 2018 12:21:45 +0200 (CEST)
In-Reply-To: <20180424021511.17430-1-thomas@monjalon.net>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/24/2018 3:15 AM, Thomas Monjalon wrote:
> The basic operations for ports enumeration should not be
> considered as experimental in DPDK 18.05.
> 
> The iterator RTE_ETH_FOREACH_DEV was introduced in DPDK 17.05.
> It uses the function the rte_eth_find_next_owned_by() to get
> only ownerless ports. Its API can be considered stable.
> So the flag experimental is removed from rte_eth_find_next_owned_by().
> 
> The flag experimental is removed from rte_eth_dev_count_avail()
> which is the new name of the old function rte_eth_dev_count().
> 
> The flag experimental is set to rte_eth_dev_count_total()
> in the .c file for consistency with the declaration in the .h file.
> 
> A lot of internal applications are fixed to not allow experimental API.
> 
> Fixes: 8728ccf37615 ("fix ethdev ports enumeration")
> Fixes: d9a42a69febf ("ethdev: deprecate port count function")
> Fixes: e70e26861eaf ("net/mvpp2: fix build")
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Getting some build errors [1], it seems some samples are using some other
experimental APIs so that we can't remove the flag for them.


[1]
.../dpdk/examples/tep_termination/main.c: In function ‘main’:
.../dpdk/examples/tep_termination/main.c:1209:3: error: ‘rte_ctrl_thread_create’
is deprecated: Symbol is not yet part of stable ABI
[-Werror=deprecated-declarations]
   ret = rte_ctrl_thread_create(&tid, "print-stats", NULL,
   ^~~

.../dpdk/examples/vhost/main.c: In function ‘main’:
.../dpdk/examples/vhost/main.c:1497:3: error: ‘rte_ctrl_thread_create’ is
deprecated: Symbol is not yet part of stable ABI [-Werror=deprecated-declarations]
   ret = rte_ctrl_thread_create(&tid, "print-stats", NULL,
   ^~~