From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [PATCH v5 05/11] mbuf: add security crypto flags and
	mbuf fields
Date: Wed, 25 Oct 2017 17:35:39 +0530
Message-ID: <83fd3af3-2e9b-11ca-5d6a-f64df341dba7@nxp.com>
References: <20171014221734.15511-1-akhil.goyal@nxp.com>
 <20171024141545.30837-1-akhil.goyal@nxp.com>
 <20171024141545.30837-6-akhil.goyal@nxp.com>
 <20171025093816.w5ujncito5o7qjuj@platinum>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <declan.doherty@intel.com>,
 <pablo.de.lara.guarch@intel.com>, <hemant.agrawal@nxp.com>,
 <radu.nicolau@intel.com>, <borisp@mellanox.com>, <aviadye@mellanox.com>,
 <thomas@monjalon.net>, <sandeep.malik@nxp.com>,
 <jerin.jacob@caviumnetworks.com>, <john.mcnamara@intel.com>,
 <konstantin.ananyev@intel.com>, <shahafs@mellanox.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-CY1-obe.outbound.protection.outlook.com
 (mail-cys01nam02on0066.outbound.protection.outlook.com [104.47.37.66])
 by dpdk.org (Postfix) with ESMTP id 25E8C1B1F7
 for <dev@dpdk.org>; Wed, 25 Oct 2017 14:05:48 +0200 (CEST)
In-Reply-To: <20171025093816.w5ujncito5o7qjuj@platinum>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Olivier,
On 10/25/2017 3:08 PM, Olivier MATZ wrote:
> On Tue, Oct 24, 2017 at 07:45:39PM +0530, Akhil Goyal wrote:
>> From: Boris Pismenny <borisp@mellanox.com>
>>
>> Add security crypto flags and update mbuf fields to support
>> IPsec crypto offload for transmitted packets, and to indicate
>> crypto result for received packets.
>>
>> Signed-off-by: Aviad Yehezkel <aviadye@mellanox.com>
>> Signed-off-by: Boris Pismenny <borisp@mellanox.com>
>> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> 
> [...]
> 
>> --- a/lib/librte_mbuf/rte_mbuf.h
>> +++ b/lib/librte_mbuf/rte_mbuf.h
>> @@ -189,11 +189,26 @@ extern "C" {
>>    */
>>   #define PKT_RX_TIMESTAMP     (1ULL << 17)
>>   
>> +/**
>> + * Indicate that security offload processing was applied on the RX packet.
>> + */
>> +#define PKT_RX_SEC_OFFLOAD		(1ULL << 18)
>> +
>> +/**
>> + * Indicate that security offload processing failed on the RX packet.
>> + */
>> +#define PKT_RX_SEC_OFFLOAD_FAILED  (1ULL << 19)
>> +
> 
> in case you do a v6, please fix the alignment, else we'll
> fix it globally in another patch later.
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> 

will fix the alignment of the defines made in this patch.

Thanks,
Akhil