From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 5/9] pmdinfogen: move to drivers
	subdirectory
Date: Wed, 21 Jun 2017 09:57:18 +0200
Message-ID: <8418992.7tWpiUoDtu@xps>
References: <cover.1496877060.git.gaetan.rivet@6wind.com>
 <cover.1497999952.git.gaetan.rivet@6wind.com>
 <78a1d2393d08ec3152f01be35d29401447ce616f.1497999952.git.gaetan.rivet@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A3763324E
 for <dev@dpdk.org>; Wed, 21 Jun 2017 09:57:19 +0200 (CEST)
In-Reply-To: <78a1d2393d08ec3152f01be35d29401447ce616f.1497999952.git.gaetan.rivet@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

21/06/2017 01:36, Gaetan Rivet:
> pmdinfogen has a dependency on the PCI bus. The latter must be built
> first.

I think it should not be moved outside of buildtools.

The build order can be fixed by installing headers before any compilation
like proposed in this RFC: http://dpdk.org/patch/25463

Another (probably better) solution is to keep basic definitions
and helpers in EAL:
	- rte_pci.h keeps only some PCI definitions and helpers
like rte_pci_addr and eal_parse_pci_BDF() in EAL
	- bus management is done in the PCI driver

For pmdinfogen, we just need struct rte_pci_id.
Other tools or applications will probably need this kind of basic
struct and functions available in EAL.