From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: rename folder to library name Date: Tue, 03 Apr 2018 12:24:15 +0200 Message-ID: <8464158.iTavIsMWKz@xps> References: <20180403092859.71589-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: John McNamara , Marko Kovacevic , dev@dpdk.org, Bruce Richardson To: Ferruh Yigit Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 528101B664 for ; Tue, 3 Apr 2018 12:24:45 +0200 (CEST) In-Reply-To: <20180403092859.71589-1-ferruh.yigit@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/04/2018 11:28, Ferruh Yigit: > Library folder name and output library name are same except a few flaws > including librte_ether. > > This library is network device abstraction layer, the name "ethdev" fits > better than "ether", and library & header files already named as ethdev. > > Also there is a rte_ether.h in the net library which can cause confusion. > > Signed-off-by: Ferruh Yigit > --- > Not sure if the we are ready for this change J > > This is one the issues that the hassle of the change doesn't worth the > benefit and you may prefer to live with the flaw. > > Also a concern is this breaks the git history. Yes it breaks the git history. I am a big user of gitk. Do you know how to follow the history after rename with gitk? I think it is a good change but I would like to be sure it will not bother us every day.