From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3] net/ring: remove unnecessary NULL check
Date: Mon, 07 Nov 2016 14:08:56 +0100
Message-ID: <8471661.hSFy5i1P0L@xps13>
References: <1478030140-7127-1-git-send-email-mauricio.vasquez@polito.it>
 <1478094369-3943-1-git-send-email-mauricio.vasquez@polito.it>
 <162c0602-5fff-fa80-98c5-3725fcb96e69@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
 bruce.richardson@intel.com
To: Mauricio Vasquez B <mauricio.vasquez@polito.it>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id 45EAF1DB1
 for <dev@dpdk.org>; Mon,  7 Nov 2016 14:08:59 +0100 (CET)
Received: by mail-wm0-f53.google.com with SMTP id t79so176150923wmt.0
 for <dev@dpdk.org>; Mon, 07 Nov 2016 05:08:59 -0800 (PST)
In-Reply-To: <162c0602-5fff-fa80-98c5-3725fcb96e69@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-11-02 14:05, Ferruh Yigit:
> On 11/2/2016 1:46 PM, Mauricio Vasquez B wrote:
> > Coverity detected this as an issue because internals->data will never be NULL,
> > then the check is not necessary.
> > 
> > Fixes: d082c0395bf6 ("ring: fix memory leak when detaching")
> > Coverity issue: 137873
> > 
> > Signed-off-by: Mauricio Vasquez B <mauricio.vasquez@polito.it>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks