From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] net/e1000: fix memcpy length error Date: Tue, 19 Sep 2017 10:32:45 +0100 Message-ID: <847856cb-d769-e2bb-d366-9e88c741626e@intel.com> References: <1505220240-30600-1-git-send-email-wang.yong19@zte.com.cn> <30f82422-1147-1b8b-4f09-d0565960044f@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Yong Wang , wenzhuo.lu@intel.com Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 68ED9160 for ; Tue, 19 Sep 2017 11:32:47 +0200 (CEST) In-Reply-To: <30f82422-1147-1b8b-4f09-d0565960044f@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/19/2017 10:16 AM, Ferruh Yigit wrote: > On 9/12/2017 1:44 PM, Yong Wang wrote: >> The size of "flex_filter.filter_info.mask" and "filter->mask" is 16 >> bytes, but the length of memcpy--"RTE_ALIGN(filter->len, sizeof(char)) >> / sizeof(char)" may reach 128 bytes which may cause array access out >> of bound. Fix it by replacing "sizeof(char)" by "CHAR_BIT". >> >> Signed-off-by: Yong Wang > > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.