From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v5 11/12] drivers: update PMDs to use rte_driver probe and remove Date: Mon, 9 Jan 2017 15:19:27 +0000 Message-ID: <8484fc57-baa7-0f84-bc05-49d7f4ca79ad@intel.com> References: <1482756644-13726-1-git-send-email-shreyansh.jain@nxp.com> <1482758645-23057-1-git-send-email-shreyansh.jain@nxp.com> <1482758645-23057-12-git-send-email-shreyansh.jain@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, thomas.monjalon@6wind.com To: Shreyansh Jain , david.marchand@6wind.com Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 34B311E2B for ; Mon, 9 Jan 2017 16:19:32 +0100 (CET) In-Reply-To: <1482758645-23057-12-git-send-email-shreyansh.jain@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/26/2016 1:24 PM, Shreyansh Jain wrote: > These callbacks now act as first layer of PCI interfaces from the Bus. > Bus probe would enter the PMDs through the rte_driver->probe/remove > callbacks, falling to rte_xxx_driver->probe/remove (Currently, all the > drivers are rte_pci_driver). > > This patch also changes QAT which is the only crypto PMD based on PCI. > All others would be changed in a separate patch focused on VDEV. > > Signed-off-by: Shreyansh Jain > --- > drivers/crypto/qat/rte_qat_cryptodev.c | 4 ++++ > drivers/net/bnx2x/bnx2x_ethdev.c | 8 ++++++++ > drivers/net/bnxt/bnxt_ethdev.c | 4 ++++ > drivers/net/cxgbe/cxgbe_ethdev.c | 4 ++++ > drivers/net/e1000/em_ethdev.c | 4 ++++ > drivers/net/e1000/igb_ethdev.c | 8 ++++++++ > drivers/net/ena/ena_ethdev.c | 4 ++++ > drivers/net/enic/enic_ethdev.c | 4 ++++ > drivers/net/fm10k/fm10k_ethdev.c | 4 ++++ > drivers/net/i40e/i40e_ethdev.c | 4 ++++ > drivers/net/i40e/i40e_ethdev_vf.c | 4 ++++ > drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++++++ > drivers/net/mlx4/mlx4.c | 3 ++- > drivers/net/mlx5/mlx5.c | 3 ++- > drivers/net/nfp/nfp_net.c | 4 ++++ > drivers/net/qede/qede_ethdev.c | 8 ++++++++ > drivers/net/szedata2/rte_eth_szedata2.c | 4 ++++ > drivers/net/thunderx/nicvf_ethdev.c | 4 ++++ > drivers/net/virtio/virtio_ethdev.c | 2 ++ > drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++++ > 20 files changed, 90 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/qat/rte_qat_cryptodev.c b/drivers/crypto/qat/rte_qat_cryptodev.c > index 1e7ee61..bc1a9c6 100644 > --- a/drivers/crypto/qat/rte_qat_cryptodev.c > +++ b/drivers/crypto/qat/rte_qat_cryptodev.c > @@ -120,6 +120,10 @@ crypto_qat_dev_init(__attribute__((unused)) struct rte_cryptodev_driver *crypto_ > > static struct rte_cryptodev_driver rte_qat_pmd = { > .pci_drv = { > + .driver = { > + .probe = rte_eal_pci_probe, > + .remove = rte_eal_pci_remove, > + }, Since this part is common for all PCI drivers, why not make this part of RTE_PMD_REGISTER_PCI macro? <...>