From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4] build: move variable definition to top level Date: Sun, 24 Mar 2019 23:59:22 +0100 Message-ID: <8490098.mdA5AMzK3V@xps> References: <1551952591-102518-1-git-send-email-andrius.sirvys@intel.com> <1551958101-104223-1-git-send-email-andrius.sirvys@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, bruce.richardson@intel.com To: Andrius Sirvys Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C2D16A3 for ; Sun, 24 Mar 2019 23:59:25 +0100 (CET) In-Reply-To: <1551958101-104223-1-git-send-email-andrius.sirvys@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/03/2019 12:28, Andrius Sirvys: > If for debugging we disable the driver directory in the meson.build file, > we get an error because the variable "driver_classes" does not exist. > This is because driver_classes is only defined in the > drivers/meson.build file. Defining driver_classes in dpdk/meson.build file > will make it easier for compiling separate directories. > > In the process, we rename driver_classes to dpdk_driver_classes for > consistency with the other variables. > > Signed-off-by: Andrius Sirvys > Acked-by: Bruce Richardson > --- > v4: Removed unreleated files that were accidentally included > --- > drivers/meson.build | 4 ++-- > meson.build | 3 ++- > 2 files changed, 4 insertions(+), 3 deletions(-) Please, could you rebase on top of latest changes in master? Thanks