From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v6 4/4] latencystats: added new library for
	latency stats
Date: Thu, 12 Jan 2017 14:41:24 +0100
Message-ID: <8494765.8zaa745I9T@xps13>
References: <1484150594-3758-1-git-send-email-remy.horton@intel.com>
 <1484150594-3758-5-git-send-email-remy.horton@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, olivier.matz@6wind.com
To: Remy Horton <remy.horton@intel.com>,
 Reshma Pattan <reshma.pattan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id BBE3DF8AA
 for <dev@dpdk.org>; Thu, 12 Jan 2017 14:41:14 +0100 (CET)
Received: by mail-wm0-f44.google.com with SMTP id r126so18861020wmr.0
 for <dev@dpdk.org>; Thu, 12 Jan 2017 05:41:14 -0800 (PST)
In-Reply-To: <1484150594-3758-5-git-send-email-remy.horton@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-01-12 00:03, Remy Horton:
> Add a library designed to calculate latency statistics and report them
> to the application when queried. The library measures minimum, average and
> maximum latencies, and jitter in nano seconds. The current implementation
> supports global latency stats, i.e. per application stats.

Is it specific to ethdev ports?

> Added new field to mbuf struct to mark the packet arrival time on Rx.

There was another patch adding a timestamp in mbuf:
	http://dpdk.org/ml/archives/dev/2016-October/048809.html

> Modify testpmd code to initialize/uninitialize latency statistics
> calulation.
> 
> Modify the dpdk-procinfo process to display the newly added metrics.
> Added new command line option "--metrics" to display metrics.

It should be a separate patch.

> APIs:
> 
> * Added APIs to initialize and un initialize latency stats
>   calculation.
> * Added API to retrieve latency stats names and values.

Why bitrate and latencies are separate libs?