From mboxrd@z Thu Jan 1 00:00:00 1970 From: Raz Amir Subject: Re: [PATCH v3] pci: save list of detached devices, and re-probe during driver unload Date: Mon, 9 Mar 2015 10:07:29 +0200 Message-ID: <84B1AA3E-21E4-4A41-ADEE-B37E27147243@gmail.com> References: <1424932400-66862-1-git-send-email-razamir22@gmail.com> <1425467754-2693-1-git-send-email-razamir22@gmail.com> Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable To: "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: <1425467754-2693-1-git-send-email-razamir22-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi, gentle reminder about this patch... On Mar 4, 2015, at 1:15 PM, Raz Amir wrote: Added code that saves the pointers to the detached devices, during driver loading, and during driver unloading, go over the list, and re-attach them by calling device_probe_and_attach on each device. Signed-off-by: Raz Amir --- lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 32 ++++++++++++++++++++++++++++---= - 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c b/lib/librte_eal/bsdapp= /nic_uio/nic_uio.c index 5ae8560..78e4dea 100644 --- a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c +++ b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c @@ -55,6 +55,9 @@ __FBSDID("$FreeBSD$"); #define MAX_BARS (PCIR_MAX_BAR_0 + 1) +#define MAX_DETACHED_DEVICES 128 +static device_t detached_devices[MAX_DETACHED_DEVICES] =3D {}; +static int num_detached =3D 0; struct nic_uio_softc { device_t dev_t; @@ -289,16 +292,37 @@ nic_uio_load(void) dev =3D pci_find_bsf(bus, device, function); if (dev !=3D NULL) - for (i =3D 0; i < NUM_DEVICES; i++) - if (pci_get_vendor(dev) =3D=3D devices[i].vend && - pci_get_device(dev) =3D=3D devices[i].dev) - device_detach(dev); + continue; + =20 + for (i =3D 0; i < NUM_DEVICES; i++) + if (pci_get_vendor(dev) =3D=3D devices[i].vend && + pci_get_device(dev) =3D=3D devices[i].dev) { + if (num_detached < MAX_DETACHED_DEVICES) { + printf("nic_uio_load: detaching and storing dev= =3D%p\n", dev); + detached_devices[num_detached++] =3D dev; + } + else + printf("nic_uio_load: reached MAX_DETACHED_DEVI= CES=3D%d. dev=3D%p won't be reattached\n", + MAX_DETACHED_DEVICES, dev); + device_detach(dev); + } } } static void nic_uio_unload(void) { + int i; + printf("nic_uio_unload: entered ... \n"); + + for (i =3D 0; i < num_detached; i++) { + printf("nic_uio_unload: calling to device_probe_and_attach for dev=3D= %p...\n", + detached_devices[i]); + device_probe_and_attach(detached_devices[i]); + printf("nic_uio_unload: done.\n"); + } + + printf("nic_uio_unload: leaving ... \n"); } static int --=20 2.1.2