From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wiles, Keith" Subject: Re: [PATCH 1/2] eal: add API to align integer to previous power of 2 Date: Mon, 19 Feb 2018 13:55:33 +0000 Message-ID: <8522C580-BFB3-4D1B-A331-45DA05427D50@intel.com> References: <20180217104934.17291-1-pbhagavatula@caviumnetworks.com> <28F3DAA5-CCAB-4D2E-A6C9-FEB685A619C8@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , "Thomas Monjalon" , "dev@dpdk.org" To: Matan Azrad Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E93CA14E8 for ; Mon, 19 Feb 2018 14:55:35 +0100 (CET) In-Reply-To: Content-Language: en-US Content-ID: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Feb 19, 2018, at 12:03 AM, Matan Azrad wrote: >=20 >=20 >>=20 >> Is this the type of API that needs to be marked experimental, >=20 > I think it is relevant to any exposed API(not only for internal libraries= ). >=20 >> we should be able to prove these functions, correct? >=20 > Don't we need to prove any function in DPDK? > What is your point? My point is this is a inline function and can not be placed in the .map fil= e as a external API. These simple type of APIs are easy to prove and making= them experimental seems to just cause an extra step. If the functions are = not required that is a different problem or if the API is really only ever = used by a single function or module of files then it should be moved to the= module/file and made locate to the module/file. >=20 >>> Matan >>=20 >> Regards, >> Keith Regards, Keith