From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 4/4] szedata2: add 100G link speed Date: Tue, 15 Mar 2016 14:41:56 +0100 Message-ID: <8527284.jAONBlNGsn@xps13> References: <1457992546-32230-1-git-send-email-thomas.monjalon@6wind.com> <1458047529-6522-1-git-send-email-vido@cesnet.cz> <1458047529-6522-5-git-send-email-vido@cesnet.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: marcdevel@gmail.com, dev@dpdk.org To: Matej Vido Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id CEB73558A for ; Tue, 15 Mar 2016 14:43:21 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id p65so27308752wmp.0 for ; Tue, 15 Mar 2016 06:43:21 -0700 (PDT) In-Reply-To: <1458047529-6522-5-git-send-email-vido@cesnet.cz> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks for the series completing the ethdev rework with the same splitting. 2016-03-15 14:12, Matej Vido: > Temporary 10G constant is replaced with 100G constant. > Item speed_capa from struct rte_eth_dev_info is set with 100G flag. [...] > @@ -1161,7 +1162,7 @@ eth_link_update(struct rte_eth_dev *dev, > * will be changed to support 100Gbps speed change > * this value to 100G. > */ > - link.link_speed = ETH_SPEED_NUM_10G; > + link.link_speed = ETH_SPEED_NUM_100G; Shouldn't we remove the above comment?