From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: fix linker script when re-building Date: Thu, 17 Mar 2016 21:48:09 +0100 Message-ID: <8528444.vnvGEzYpHh@xps13> References: <1458170543-47621-1-git-send-email-sergio.gonzalez.monroy@intel.com> <56EA7ADE.70009@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Panu Matilainen To: Sergio Gonzalez Monroy Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id E38072BD6 for ; Thu, 17 Mar 2016 21:49:39 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id l68so10854874wml.1 for ; Thu, 17 Mar 2016 13:49:39 -0700 (PDT) In-Reply-To: <56EA7ADE.70009@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-17 11:37, Panu Matilainen: > On 03/17/2016 01:22 AM, Sergio Gonzalez Monroy wrote: > > The linker script is generated by simply finding all libraries in > > RTE_OUTPUT/lib. > > > > The issue shows up when re-building the DPDK, hence already having a > > linker script in that directory, resulting in the linker script > > including itself. > > > > That does not play well with the linker. > > > > Simply filtering the linker script from all the found libraries solves > > the problem. > > > > Fixes: 948fd64befc3 ("mk: replace the combined library with a linker script") > > > > Signed-off-by: Sergio Gonzalez Monroy > > Oops, thanks for spotting. > > Acked-by: Panu Matilainen Applied, thanks