From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] Revert "eal: set name to threads" Date: Thu, 19 Nov 2015 13:32:44 +0100 Message-ID: <8530847.T7t25DiR7m@xps13> References: <103431910.iACTIb73WP@xps13> <1447932137-16886-1-git-send-email-ferruh.yigit@intel.com> <564DB761.5090203@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: ferruh.yigit@intel.com Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id E2BA35A6C for ; Thu, 19 Nov 2015 13:33:58 +0100 (CET) Received: by wmww144 with SMTP id w144so114467827wmw.0 for ; Thu, 19 Nov 2015 04:33:58 -0800 (PST) In-Reply-To: <564DB761.5090203@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-11-19 13:49, Panu Matilainen: > On 11/19/2015 01:22 PM, Ferruh Yigit wrote: > > This reverts commit 67b6d3039e9edbc4624c878c6930be5e126e8b58. > > > > Reverted patch uses pthread_setname_np() function, this function added > > into glibc in version 2.12 and cause a compile error in older glibc > > versions: > > error: implicit declaration of function "pthread_setname_np" > > > > Main purpose of reverted patch is to name threads, without > > pthread_setname_np() function, patch does not mean much, so reverting > > patch for sake of compatibility with older glibc versions. > > Debuggability is important too. Rather than revert, why not wrap it in > rte_thread_setname() or such and just make it a no-op with glibc > versions where pthread_setname_np() is not available? +1