From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 1/3] lib/librte_port: enable file
	descriptor port support
Date: Wed, 12 Oct 2016 22:33:17 +0200
Message-ID: <8534270.5teDzHbgep@xps13>
References: <1470432064-59047-1-git-send-email-jasvinder.singh@intel.com>
 <1472999921-43283-1-git-send-email-jasvinder.singh@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, cristian.dumitrescu@intel.com
To: Jasvinder Singh <jasvinder.singh@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com
 [209.85.220.181]) by dpdk.org (Postfix) with ESMTP id 4E6C5231C
 for <dev@dpdk.org>; Wed, 12 Oct 2016 22:33:20 +0200 (CEST)
Received: by mail-qk0-f181.google.com with SMTP id z190so54101021qkc.2
 for <dev@dpdk.org>; Wed, 12 Oct 2016 13:33:20 -0700 (PDT)
In-Reply-To: <1472999921-43283-1-git-send-email-jasvinder.singh@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-09-04 15:38, Jasvinder Singh:
> +#define RTE_PORT_FD_READER_STATS_PKTS_IN_ADD(port, val) \
> +       do { port->stats.n_pkts_in += val } while (0)
> +#define RTE_PORT_FD_READER_STATS_PKTS_DROP_ADD(port, val) \
> +       do { port->stats.n_pkts_drop += val } while (0)
> +

It does not compile because of missing ;

> + *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.

The years seem outdated.

This patchset was probably not tested as it does not compile.
And it could be useless if a TAP PMD is integrated.
I suggest to wait 17.02 cycle and see.