From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] eal/linux: fix build
Date: Thu, 05 Mar 2015 10:51:57 +0100
Message-ID: <8539092.UnIgVbWq12@xps13>
References: <1425372295-27839-1-git-send-email-thomas.monjalon@6wind.com>
 <1637153.LCrn9VkBbJ@xps13>
 <533710CFB86FA344BFBF2D6802E60286CEED33@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "Qiu, Michael" <michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <533710CFB86FA344BFBF2D6802E60286CEED33-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Michael,

2015-03-05 09:13, Qiu, Michael:
> On 3/4/2015 6:24 AM, Thomas Monjalon wrote:
> >>> Compilation fails in some distributions because of missing unistd=
.h
> >>> needed for pread/pwrite (seen with Suse):
> >>>         lib/librte_eal/linuxapp/eal/eal_pci_uio.c:62:2:
> >>>         error: implicit declaration of function =E2=80=98pread=E2=
=80=99
> >>>
> >>> Fixes: 4a499c649590 ("eal/linux: enable uio_pci_generic support")=

> >>>
> >>> Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> >> Acked-by: David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> > Applied
>=20
> Hi, Thomas
>=20
> This patch may be need to be reverted, as the error still exists.

No I don't think it should be reverted. It must be completed.

[...]
> NAME
>        pread, pwrite - read from or write to a file descriptor at a
> given offset
>=20
> SYNOPSIS
>        #define _XOPEN_SOURCE 500
>=20
>        #include <unistd.h>
[...]
> While I try to add marco #define _XOPEN_SOURCE 500

I think that the good thing to do.

> Other errors show up

Are they hard to fix?

> Who knows how to solve this issue?