From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: i40e mbuf->rss indication
Date: Thu, 22 Mar 2018 12:18:16 +0000
Message-ID: <856b65d4-a35f-3b2e-73d4-dbfdf105b9c6@intel.com>
References: <782383cd531a4248a3634705f46d8acf@XCH-RTP-017.cisco.com>
 <20180322113457.GB608@bricha3-MOBL.ger.corp.intel.com>
 <ec9c18bf00824413af21053d27fb1427@XCH-RTP-017.cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Hanoch Haim (hhaim)" <hhaim@cisco.com>,
 Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 2EE115593
 for <dev@dpdk.org>; Thu, 22 Mar 2018 13:18:19 +0100 (CET)
In-Reply-To: <ec9c18bf00824413af21053d27fb1427@XCH-RTP-017.cisco.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/22/2018 11:46 AM, Hanoch Haim (hhaim) wrote:
> Driver: i40e
> 
> DPDK : 17.11
> 
> Configuration : 
> 
> 1)     RSS configuration 
>        rxmode.mq_mode = ETH_MQ_RX_RSS;
>        rss->rss_hf = ETH_RSS_UDP | ETH_RSS_TCP;
>        rss->rss_key = Microsoft key 
>        rss->rss_key_len = 52
> 
>        *configure RETA to some rx-queues
> 
> 2)        Change hash to TOEPLITZ (only for i40e)
> 
>           struct rte_eth_hash_filter_info info = {};
>           info.info_type = RTE_ETH_HASH_FILTER_GLOBAL_CONFIG;
>           info.info.global_conf.hash_func = RTE_ETH_HASH_FUNCTION_TOEPLITZ;
>           rte_eth_dev_filter_ctrl(m_repid, 
>                                   RTE_ETH_FILTER_HASH,
>                                   RTE_ETH_FILTER_SET, &info);
> 
> 3) Configure some flow-director rules 
> 
> 4) TCP/UDP packets are received to the *right* core (based on a SW Toeplitz calculation +reta table) however
>    The reported rss value is *wrong* in the mbuf 
>   (m->hash.rss == *wrong value*)

Are you getting same result with both scalar and vector driver?

>   ((m->ol_flags&PKT_RX_RSS_HASH) == PKT_RX_RSS_HASH
> 
> 5) The above works fine for mlx5 and ixgbe
> 
> 6) I suspect the hash is something else, maybe flow-director id or xor hash ..
> 
> Wanted to know if this is a known issue. I can provide a simple way to reproduce it using TRex 
> 
> Thanks,
> Hanoh
> 
> 
> -----Original Message-----
> From: Bruce Richardson [mailto:bruce.richardson@intel.com] 
> Sent: Thursday, March 22, 2018 1:35 PM
> To: Hanoch Haim (hhaim)
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] i40e mbuf->rss indication
> 
> On Wed, Mar 21, 2018 at 06:47:22PM +0000, Hanoch Haim (hhaim) wrote:
>> Hi All,
>> DPDK:17.11
>> When i40e is configured with RSS enabled and hash.type=toeplitz
>>
>> m->hash.rss = some weird number
>> ((m->ol_flags&PKT_RX_RSS_HASH) == PKT_RX_RSS_HASH
>>
>> The hash value is correct and match the MS Toeplitz standard.
>>
>> Is this expected?
> 
> I'm sorry, but I don't quite follow the question, or the problem. Are you meaning to say that the hash value is incorrect, or that the flag is not being set or something else?
> 
> /Bruce
> 
>>
>> The above works fine with ixgbe/mlx5
>>
>> Thanks,
>> Hanoh
>>