From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH v9 17/25] drivers: convert PMD_VDEV drivers to use rte_vdev_driver Date: Mon, 12 Sep 2016 10:09:45 +0530 Message-ID: <85ebcf69-680f-3051-94e2-2da1bcf24d35@nxp.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1473257297-7221-1-git-send-email-shreyansh.jain@nxp.com> <1473257297-7221-18-git-send-email-shreyansh.jain@nxp.com> <20160911115553.GU23158@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , Jan Viktorin , Thomas Monjalon To: Yuanhan Liu Return-path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0047.outbound.protection.outlook.com [104.47.36.47]) by dpdk.org (Postfix) with ESMTP id B576D29CF for ; Mon, 12 Sep 2016 06:39:21 +0200 (CEST) In-Reply-To: <20160911115553.GU23158@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi , On Sunday 11 September 2016 05:25 PM, Yuanhan Liu wrote: > On Wed, Sep 07, 2016 at 07:38:09PM +0530, Shreyansh Jain wrote: >> All PMD_VDEV drivers can now use rte_vdev_driver instead of the >> rte_driver (which is embedded in the rte_vdev_driver). >> >> Signed-off-by: Jan Viktorin >> Signed-off-by: Shreyansh Jain > > Hi, > > FYI, my testrobot caught some errors when this patch is applied. > > --yliu > > i686-native-linuxapp-gcc: config-all-yes-shared > =============================================== > rte_eth_af_packet.o: In function `vdrvinitfn_pmd_af_packet_drv': > rte_eth_af_packet.c:(.text.startup+0x23): undefined reference to `rte_eal_vdrv_register' > collect2: error: ld returned 1 exit status > make[6]: *** [librte_pmd_af_packet.so.1.1] Error 1 > make[5]: *** [af_packet] Error 2 > make[5]: *** Waiting for unfinished jobs.... > rte_eth_bond_pmd.o: In function `vdrvinitfn_bond_drv': > rte_eth_bond_pmd.c:(.text.startup+0x23): undefined reference to `rte_eal_vdrv_register' > collect2: error: ld returned 1 exit status > make[6]: *** [librte_pmd_bond.so.1.1] Error 1 > make[5]: *** [bonding] Error 2 > make[4]: *** [net] Error 2 > make[3]: *** [drivers] Error 2 > make[2]: *** [all] Error 2 > make[1]: *** [pre_install] Error 2 > make: *** [install] Error 2 > error: build failed > Thanks! I think this is similar to what Ferruh has commented in [1]. I missed adding these functions to the map file in the 16th patch which is why shared library is failing. I have noted that for change in v10 as and when that is ready. [1] http://dpdk.org/ml/archives/dev/2016-September/046399.html -- Shreyansh