From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2 1/4] add missing static keyword to globals
Date: Sun, 28 Oct 2018 12:04:23 +0100
Message-ID: <8612622.zZWGxMPIhl@xps>
References: <20181004034047.26824-1-ferruh.yigit@intel.com>
 <20181005162612.31906-1-ferruh.yigit@intel.com>
 <bf870874-bc3d-a142-119b-608aea894536@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Andrew Rybchenko <arybchenko@solarflare.com>,
 Reshma Pattan <reshma.pattan@intel.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>,
 Ashish Gupta <ashish.gupta@cavium.com>,
 Fiona Trahe <fiona.trahe@intel.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 Akhil Goyal <akhil.goyal@nxp.com>,
 Declan Doherty <declan.doherty@intel.com>,
 Fan Zhang <roy.fan.zhang@intel.com>,
 Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 Gaetan Rivet <gaetan.rivet@6wind.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Xiao Wang <xiao.w.wang@intel.com>, Beilei Xing <beilei.xing@intel.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Rasesh Mody <rasesh.mody@cavium.com>,
 Harish Patil <harish.patil@cavium.com>,
 Shahed Shaikh <shahed.shaikh@cavium.com>,
 Jasvinder Singh <jasvinder.singh@intel.com>,
 Cristian D
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 208132B91
 for <dev@dpdk.org>; Sun, 28 Oct 2018 12:04:22 +0100 (CET)
In-Reply-To: <bf870874-bc3d-a142-119b-608aea894536@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

05/10/2018 17:55, Andrew Rybchenko:
> On 10/5/18 7:26 PM, Ferruh Yigit wrote:
> > --- a/drivers/net/sfc/sfc_rx.c
> > +++ b/drivers/net/sfc/sfc_rx.c
> > -struct sfc_rss_hf_rte_to_efx sfc_rss_hf_map[] = {
> > +static struct sfc_rss_hf_rte_to_efx sfc_rss_hf_map[] = {
> 
> I'd prefer "static const" in fact

Yes, please add const to such structures in a v3.