From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH v3 2/2] devtools: fix result of svg include check Date: Fri, 01 Mar 2019 18:52:20 +0100 Message-ID: <86213097.jjelSHenU9@xps> References: <20190214193547.30783-1-msantana@redhat.com> <20190301170806.3547-1-msantana@redhat.com> <20190301170806.3547-3-msantana@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: stable@dpdk.org, dev@dpdk.org, Bruce Richardson , Van Haaren Harry , ramirose@gmail.com To: Michael Santana Return-path: In-Reply-To: <20190301170806.3547-3-msantana@redhat.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/03/2019 18:08, Michael Santana: > Fix trivial bug. In sh shell, 'foo = 1' is not the same as > 'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo > as a command, rather than a simple variable assignment. > > Signed-off-by: Michael Santana > Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks") CC: stable@dpdk.org must be inserted below Fixes for the record in git. Note also that Signed-off-by must be below with a blank line.