From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 08/12] net/bnxt: use correct macro to
 register VF async event completion ring
Date: Tue, 25 Sep 2018 12:30:13 +0100
Message-ID: <862648c7-bf26-7ddd-aee1-08c2d2a1b299@intel.com>
References: <f08457f7-5a78-c7e4-23ff-f4e253cd54c9@intel.com>
 <20180922045559.27438-1-ajit.khaparde@broadcom.com>
 <20180922045559.27438-9-ajit.khaparde@broadcom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: yongping <yongping.zhang@broadcom.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id CF7A37CD2
 for <dev@dpdk.org>; Tue, 25 Sep 2018 13:30:28 +0200 (CEST)
In-Reply-To: <20180922045559.27438-9-ajit.khaparde@broadcom.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/22/2018 5:55 AM, Ajit Khaparde wrote:
> From: yongping <yongping@broadcom.com>
> 
> While registering vf's event completion ring to FW, use the wrong
> macro, FW doesn't set up the event completion ring successfully,
> VF can't receive any async event.

Isn't this a fix that you would want to backport?

If so can you please update the commit log according, and perhaps it can be
better to move this patch before HWRM update patch, to help stable tree maintainers.

> 
> Signed-off-by: yongping <yongping@broadcom.com>

Can you please use "Name Surname <mail_address_all_lowercase>" syntax?

> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/bnxt_hwrm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
> index 62da254b9..51fe3a4c2 100644
> --- a/drivers/net/bnxt/bnxt_hwrm.c
> +++ b/drivers/net/bnxt/bnxt_hwrm.c
> @@ -3001,7 +3001,7 @@ int bnxt_hwrm_vf_func_cfg_def_cp(struct bnxt *bp)
>  	HWRM_PREP(req, FUNC_VF_CFG, BNXT_USE_CHIMP_MB);
>  
>  	req.enables = rte_cpu_to_le_32(
> -			HWRM_FUNC_CFG_INPUT_ENABLES_ASYNC_EVENT_CR);
> +			HWRM_FUNC_VF_CFG_INPUT_ENABLES_ASYNC_EVENT_CR);
>  	req.async_event_cr = rte_cpu_to_le_16(
>  			bp->def_cp_ring->cp_ring_struct->fw_ring_id);
>  	rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
>