From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH] devbind: don't display non-existent device categories Date: Mon, 19 Nov 2018 10:03:40 +0000 Message-ID: <864f7743-aaaf-8f6a-d37e-c182a9b4f88d@intel.com> References: <07b7c67be5adc770b028212ef8918d4ae8f11255.1542127066.git.anatoly.burakov@intel.com> <2050019.mpedAaAYAq@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, david.hunt@intel.com, john.mcnamara@intel.com, ferruh.yigit@intel.com To: Thomas Monjalon Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 005652B92 for ; Mon, 19 Nov 2018 11:03:43 +0100 (CET) In-Reply-To: <2050019.mpedAaAYAq@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 18-Nov-18 11:13 PM, Thomas Monjalon wrote: > 13/11/2018 17:42, Anatoly Burakov: >> --- a/usertools/dpdk-devbind.py >> +++ b/usertools/dpdk-devbind.py >> + n_devs = len(dpdk_drv) + len(kernel_drv) + len(no_drv) >> + >> + # don't bother displaying anything if there are no devices >> + if n_devs == 0: >> + msg = "No '%s' devices detected" % device_name >> + print("") >> + print(msg) >> + print("".join('=' * len(msg))) >> + return >> + > > Indentation is wrong here: > TabError: inconsistent use of tabs and spaces in indentation > Oops, auto indentation in my editor strikes again... i'll submit a v2. -- Thanks, Anatoly