From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 5/6] ethdev: remove deprecated
	attach/detach functions
Date: Tue, 16 Oct 2018 14:12:37 +0200
Message-ID: <8663188.1RSN3G5ysp@xps>
References: <20181007222554.4886-1-thomas@monjalon.net>
 <20181009223338.18307-6-thomas@monjalon.net>
 <9a6e10d4-be5e-5da6-c34f-aa3d4e2ed288@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, gaetan.rivet@6wind.com, ophirmu@mellanox.com,
 arybchenko@solarflare.com
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A574A5B2C
 for <dev@dpdk.org>; Tue, 16 Oct 2018 14:12:36 +0200 (CEST)
In-Reply-To: <9a6e10d4-be5e-5da6-c34f-aa3d4e2ed288@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

16/10/2018 13:03, Ferruh Yigit:
> On 10/9/2018 11:33 PM, Thomas Monjalon wrote:
> > The hotplug attach/detach features are implemented in EAL layer.
> > There is a new ethdev iterator to retrieve ports from ethdev layer.
> > 
> > As announced earlier, the (buggy) ethdev functions are now removed.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
> 
> <...>
> 
> > @@ -53,7 +53,6 @@ Programmer's Guide
> >      packet_framework
> >      vhost_lib
> >      metrics_lib
> > -    port_hotplug_framework
> 
> Any replacement documentation for hotplug?

No.
We should improve the documentation about device management in general.
I will try to improve it after -rc2.

> > +* ethdev: The deprecated functions attach/detach were removed in 18.11.
> > +  ``rte_eth_dev_attach`` can be replaced by ``RTE_ETH_FOREACH_MATCHING_DEV``
> > +  and ``rte_dev_probe`` or ``rte_eal_hotplug_add``.
> > +  ``rte_eth_dev_detach`` can be replaced by
> > +  ``rte_dev_remove`` or ``rte_eal_hotplug_remove``.
> 
> What is the difference between ``rte_dev_remove`` or ``rte_eal_hotplug_remove``,
> which one is good for which usage, is there any documentation explaining this?

In doxygen, you can see that the parameters are differents, and new ones
are experimental.
That's why we'll keep old ones, at least for this release.